From 87adbbce37f6615713c3503180ac7aeaeeadb106 Mon Sep 17 00:00:00 2001 From: bhaveshrp Date: Sat, 12 Nov 2022 22:17:22 +0530 Subject: [PATCH 1/4] fix pylints redefined-outer-name warnings --- pandas/core/dtypes/inference.py | 6 +++--- pandas/core/frame.py | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pandas/core/dtypes/inference.py b/pandas/core/dtypes/inference.py index de240a39e2951..421393a5c7b94 100644 --- a/pandas/core/dtypes/inference.py +++ b/pandas/core/dtypes/inference.py @@ -417,8 +417,8 @@ def is_dataclass(item): """ try: - from dataclasses import is_dataclass - - return is_dataclass(item) and not isinstance(item, type) + import dataclasses as dcs + + return dcs.is_dataclass(item) and not isinstance(item, type) except ImportError: return False diff --git a/pandas/core/frame.py b/pandas/core/frame.py index efad2edddf360..f554a360e0c3b 100644 --- a/pandas/core/frame.py +++ b/pandas/core/frame.py @@ -6493,9 +6493,9 @@ def drop_duplicates( inplace = validate_bool_kwarg(inplace, "inplace") ignore_index = validate_bool_kwarg(ignore_index, "ignore_index") - duplicated = self.duplicated(subset, keep=keep) + duplicate = self.duplicated(subset, keep=keep) - result = self[-duplicated] + result = self[-duplicate] if ignore_index: result.index = default_index(len(result)) From d13007df94a28f01f87cdbc410f115233c7e5671 Mon Sep 17 00:00:00 2001 From: bhaveshrp Date: Sat, 12 Nov 2022 23:07:00 +0530 Subject: [PATCH 2/4] fix pre-commit error --- pandas/core/dtypes/inference.py | 1 - 1 file changed, 1 deletion(-) diff --git a/pandas/core/dtypes/inference.py b/pandas/core/dtypes/inference.py index 421393a5c7b94..ee3fecec1935c 100644 --- a/pandas/core/dtypes/inference.py +++ b/pandas/core/dtypes/inference.py @@ -418,7 +418,6 @@ def is_dataclass(item): """ try: import dataclasses as dcs - return dcs.is_dataclass(item) and not isinstance(item, type) except ImportError: return False From f202d8bacc83a75f2f6dcf318ebebedaeb70e198 Mon Sep 17 00:00:00 2001 From: bhaveshrp Date: Sat, 12 Nov 2022 23:24:30 +0530 Subject: [PATCH 3/4] fix pre-commit error --- pandas/core/dtypes/inference.py | 1 + 1 file changed, 1 insertion(+) diff --git a/pandas/core/dtypes/inference.py b/pandas/core/dtypes/inference.py index ee3fecec1935c..54f3fdbab7bce 100644 --- a/pandas/core/dtypes/inference.py +++ b/pandas/core/dtypes/inference.py @@ -418,6 +418,7 @@ def is_dataclass(item): """ try: import dataclasses as dcs + return dcs.is_dataclass(item) and not isinstance(item, type) except ImportError: return False From f81e3de28f84a45c64e0e27f33bf68d01468692c Mon Sep 17 00:00:00 2001 From: bhaveshrp Date: Sat, 12 Nov 2022 23:36:48 +0530 Subject: [PATCH 4/4] fix the changes requested --- pandas/core/dtypes/inference.py | 4 ++-- pandas/core/frame.py | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/pandas/core/dtypes/inference.py b/pandas/core/dtypes/inference.py index 54f3fdbab7bce..3c28bd0c0a843 100644 --- a/pandas/core/dtypes/inference.py +++ b/pandas/core/dtypes/inference.py @@ -417,8 +417,8 @@ def is_dataclass(item): """ try: - import dataclasses as dcs + import dataclasses - return dcs.is_dataclass(item) and not isinstance(item, type) + return dataclasses.is_dataclass(item) and not isinstance(item, type) except ImportError: return False diff --git a/pandas/core/frame.py b/pandas/core/frame.py index f554a360e0c3b..b465761c45c78 100644 --- a/pandas/core/frame.py +++ b/pandas/core/frame.py @@ -6493,9 +6493,8 @@ def drop_duplicates( inplace = validate_bool_kwarg(inplace, "inplace") ignore_index = validate_bool_kwarg(ignore_index, "ignore_index") - duplicate = self.duplicated(subset, keep=keep) - result = self[-duplicate] + result = self[-self.duplicated(subset, keep=keep)] if ignore_index: result.index = default_index(len(result))