From a5a0a29dbb5e2ffb7af4cfe3c295fe00dceeed18 Mon Sep 17 00:00:00 2001 From: rxd330 Date: Fri, 18 Mar 2022 19:13:27 +0000 Subject: [PATCH 1/4] TST: tests added pre GH46313 --- pandas/tests/dtypes/test_dtypes.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/pandas/tests/dtypes/test_dtypes.py b/pandas/tests/dtypes/test_dtypes.py index f077317e7ebbe..580d136505210 100644 --- a/pandas/tests/dtypes/test_dtypes.py +++ b/pandas/tests/dtypes/test_dtypes.py @@ -1107,3 +1107,15 @@ def test_compare_complex_dtypes(): with pytest.raises(TypeError, match=msg): df.lt(df.astype(object)) + + +def test_categorical_of_booleans_is_boolean(): + # https://github.com/pandas-dev/pandas/issues/46313 + df = pd.DataFrame( + {"int_cat": [1, 2, 3], "bool_cat": [True, False, False]}, dtype="category" + ) + value = df["bool_cat"].cat.categories.dtype + expected = np.dtype(np.bool_) + not_expected = np.dtype(np.object_) + assert value is expected + assert value is not not_expected From 931147c828f77d8c86cd3473f9ddddcba5e823bb Mon Sep 17 00:00:00 2001 From: rxd330 Date: Tue, 5 Apr 2022 18:37:24 +0000 Subject: [PATCH 2/4] test added --- pandas/tests/tseries/frequencies/test_inference.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/pandas/tests/tseries/frequencies/test_inference.py b/pandas/tests/tseries/frequencies/test_inference.py index 704028a7827cd..9db48b45fbb4f 100644 --- a/pandas/tests/tseries/frequencies/test_inference.py +++ b/pandas/tests/tseries/frequencies/test_inference.py @@ -20,6 +20,8 @@ Timestamp, date_range, period_range, + DataFrame, + Timedelta ) import pandas._testing as tm from pandas.core.tools.datetimes import to_datetime @@ -507,3 +509,13 @@ def test_ms_vs_capital_ms(): def test_infer_freq_warn_deprecated(): with tm.assert_produces_warning(FutureWarning): frequencies.infer_freq(date_range(2022, periods=3), warn=False) + +def test_no_overflow_of_freq_and_time_in_dataframe(): + # GH 35665 + # https://github.com/pandas-dev/pandas/issues/35665 + df = DataFrame({'string_one':['2132131SSS'], 'time': [Timedelta('0 days 00:00:00.990000')]}) + try: + for _, row in df.iterrows(): + row + except OverflowError: + assert False, 'Regression, see GH 35665' \ No newline at end of file From e25a0fd3eefb70b9dcf81dc9afa9d1f1c17b608c Mon Sep 17 00:00:00 2001 From: rxd330 Date: Tue, 5 Apr 2022 19:10:47 +0000 Subject: [PATCH 3/4] pre-commit operations' --- .../tests/tseries/frequencies/test_inference.py | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/pandas/tests/tseries/frequencies/test_inference.py b/pandas/tests/tseries/frequencies/test_inference.py index 9db48b45fbb4f..dfc74cc7362f1 100644 --- a/pandas/tests/tseries/frequencies/test_inference.py +++ b/pandas/tests/tseries/frequencies/test_inference.py @@ -14,14 +14,14 @@ from pandas.compat import is_platform_windows from pandas import ( + DataFrame, DatetimeIndex, Index, Series, + Timedelta, Timestamp, date_range, period_range, - DataFrame, - Timedelta ) import pandas._testing as tm from pandas.core.tools.datetimes import to_datetime @@ -510,12 +510,15 @@ def test_infer_freq_warn_deprecated(): with tm.assert_produces_warning(FutureWarning): frequencies.infer_freq(date_range(2022, periods=3), warn=False) + def test_no_overflow_of_freq_and_time_in_dataframe(): # GH 35665 # https://github.com/pandas-dev/pandas/issues/35665 - df = DataFrame({'string_one':['2132131SSS'], 'time': [Timedelta('0 days 00:00:00.990000')]}) + df = DataFrame( + {"string_one": ["2132131SSS"], "time": [Timedelta("0 days 00:00:00.990000")]} + ) try: - for _, row in df.iterrows(): - row + for _ in df.iterrows(): + pass except OverflowError: - assert False, 'Regression, see GH 35665' \ No newline at end of file + assert False, "Regression, see GH 35665" From 2b76775aadc075a6f7562d6f62561a1855a4c8bf Mon Sep 17 00:00:00 2001 From: rxd330 Date: Tue, 5 Apr 2022 19:30:28 +0000 Subject: [PATCH 4/4] pre-commit operations --- pandas/tests/frame/test_constructors.py | 15 +++++++++++++++ .../tests/tseries/frequencies/test_inference.py | 15 --------------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/pandas/tests/frame/test_constructors.py b/pandas/tests/frame/test_constructors.py index 82c7117cc00c6..10eb367c08517 100644 --- a/pandas/tests/frame/test_constructors.py +++ b/pandas/tests/frame/test_constructors.py @@ -89,6 +89,21 @@ def test_constructor_from_2d_datetimearray(self, using_array_manager): # GH#44724 big performance hit if we de-consolidate assert len(df._mgr.blocks) == 1 + def test_no_overflow_of_freq_and_time_in_dataframe(self): + # GH 35665 + # https://github.com/pandas-dev/pandas/issues/35665 + df = DataFrame( + { + "string_one": ["2132131SSS"], + "time": [Timedelta("0 days 00:00:00.990000")], + } + ) + try: + for _, row in df.iterrows(): + row + except OverflowError: + assert False, "Regression, see GH 35665" + def test_constructor_dict_with_tzaware_scalar(self): # GH#42505 dt = Timestamp("2019-11-03 01:00:00-0700").tz_convert("America/Los_Angeles") diff --git a/pandas/tests/tseries/frequencies/test_inference.py b/pandas/tests/tseries/frequencies/test_inference.py index dfc74cc7362f1..704028a7827cd 100644 --- a/pandas/tests/tseries/frequencies/test_inference.py +++ b/pandas/tests/tseries/frequencies/test_inference.py @@ -14,11 +14,9 @@ from pandas.compat import is_platform_windows from pandas import ( - DataFrame, DatetimeIndex, Index, Series, - Timedelta, Timestamp, date_range, period_range, @@ -509,16 +507,3 @@ def test_ms_vs_capital_ms(): def test_infer_freq_warn_deprecated(): with tm.assert_produces_warning(FutureWarning): frequencies.infer_freq(date_range(2022, periods=3), warn=False) - - -def test_no_overflow_of_freq_and_time_in_dataframe(): - # GH 35665 - # https://github.com/pandas-dev/pandas/issues/35665 - df = DataFrame( - {"string_one": ["2132131SSS"], "time": [Timedelta("0 days 00:00:00.990000")]} - ) - try: - for _ in df.iterrows(): - pass - except OverflowError: - assert False, "Regression, see GH 35665"