From a63b165db43ea4716a8de22e2e0651aa023328c5 Mon Sep 17 00:00:00 2001 From: Kashif Khan <200~361477+kashifkhan@users.noreply.github.com> Date: Thu, 30 Dec 2021 08:55:10 -0600 Subject: [PATCH 1/2] TYP: fix incorrect mypy error in reshape.py --- pandas/core/reshape/reshape.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pandas/core/reshape/reshape.py b/pandas/core/reshape/reshape.py index 7edd5af7c6870..98184c12e878f 100644 --- a/pandas/core/reshape/reshape.py +++ b/pandas/core/reshape/reshape.py @@ -322,9 +322,7 @@ def get_new_columns(self, value_columns: Index | None): new_codes = [lab.take(propagator) for lab in value_columns.codes] else: - # error: Incompatible types in assignment (expression has type "List[Any]", - # variable has type "FrozenList") - new_levels = [ # type: ignore[assignment] + new_levels = [ value_columns, self.removed_level_full, ] From 58b4f63380ca7126bb4f0ac6c2add3ba6fa96949 Mon Sep 17 00:00:00 2001 From: Kashif Khan <200~361477+kashifkhan@users.noreply.github.com> Date: Thu, 30 Dec 2021 15:51:10 -0600 Subject: [PATCH 2/2] TYP: define new_leveln as FrozenList or List --- pandas/core/reshape/reshape.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pandas/core/reshape/reshape.py b/pandas/core/reshape/reshape.py index 98184c12e878f..d043e3ad53f9a 100644 --- a/pandas/core/reshape/reshape.py +++ b/pandas/core/reshape/reshape.py @@ -39,6 +39,7 @@ Index, MultiIndex, ) +from pandas.core.indexes.frozen import FrozenList from pandas.core.series import Series from pandas.core.sorting import ( compress_group_index, @@ -316,6 +317,9 @@ def get_new_columns(self, value_columns: Index | None): stride = len(self.removed_level) + self.lift width = len(value_columns) propagator = np.repeat(np.arange(width), stride) + + new_levels: FrozenList | list[Index] + if isinstance(value_columns, MultiIndex): new_levels = value_columns.levels + (self.removed_level_full,) new_names = value_columns.names + (self.removed_name,)