From 986926b5328e3f1890203676670fabdff97db8e3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Torsten=20W=C3=B6rtwein?= Date: Tue, 28 Sep 2021 19:03:35 -0400 Subject: [PATCH 1/7] TYP: enable reportMissingImports --- pandas/_libs/reshape.pyi | 2 +- pandas/_libs/tslibs/timedeltas.pyi | 2 +- pyproject.toml | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/pandas/_libs/reshape.pyi b/pandas/_libs/reshape.pyi index 893826a35d41e..245f52c65100f 100644 --- a/pandas/_libs/reshape.pyi +++ b/pandas/_libs/reshape.pyi @@ -1,6 +1,6 @@ import numpy as np -import pandas._tying as npt +import pandas._typing as npt def unstack( values: np.ndarray, # reshape_t[:, :] diff --git a/pandas/_libs/tslibs/timedeltas.pyi b/pandas/_libs/tslibs/timedeltas.pyi index 8de02aa566456..7c0131cf28c9a 100644 --- a/pandas/_libs/tslibs/timedeltas.pyi +++ b/pandas/_libs/tslibs/timedeltas.pyi @@ -7,12 +7,12 @@ from typing import ( ) import numpy as np -from pands._typing import npt from pandas._libs.tslibs import ( NaTType, Tick, ) +from pandas._typing import npt _S = TypeVar("_S") diff --git a/pyproject.toml b/pyproject.toml index 0223a1c035cbc..e983a08c3fae9 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -166,7 +166,6 @@ reportFunctionMemberAccess = false reportImportCycles = false reportIncompatibleMethodOverride = false reportIncompatibleVariableOverride = false -reportMissingImports = false reportMissingModuleSource = false reportMissingTypeArgument = false reportMissingTypeStubs = false From d48882e8faea6a94d47e32d7b7b5f9f5ce918af0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Torsten=20W=C3=B6rtwein?= Date: Tue, 28 Sep 2021 21:20:19 -0400 Subject: [PATCH 2/7] install pyxlsb and disable reportMissingImports again --- environment.yml | 1 + pyproject.toml | 1 + 2 files changed, 2 insertions(+) diff --git a/environment.yml b/environment.yml index 1cd1179fc29b0..0c42876e673a3 100644 --- a/environment.yml +++ b/environment.yml @@ -98,6 +98,7 @@ dependencies: - xlsxwriter - xlwt - odfpy + - pyxlsb - fastparquet>=0.4.0 # pandas.read_parquet, DataFrame.to_parquet - pyarrow>=0.17.0 # pandas.read_parquet, DataFrame.to_parquet, pandas.read_feather, DataFrame.to_feather diff --git a/pyproject.toml b/pyproject.toml index e983a08c3fae9..0223a1c035cbc 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -166,6 +166,7 @@ reportFunctionMemberAccess = false reportImportCycles = false reportIncompatibleMethodOverride = false reportIncompatibleVariableOverride = false +reportMissingImports = false reportMissingModuleSource = false reportMissingTypeArgument = false reportMissingTypeStubs = false From 11a31c3c782a3f1571a3b2fe8d4dff9f1c18e84e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Torsten=20W=C3=B6rtwein?= Date: Tue, 28 Sep 2021 21:30:23 -0400 Subject: [PATCH 3/7] added to requirements-dev.txt --- requirements-dev.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/requirements-dev.txt b/requirements-dev.txt index 14b9ac8a9393e..6b09f0c997eb4 100644 --- a/requirements-dev.txt +++ b/requirements-dev.txt @@ -64,6 +64,7 @@ xlrd xlsxwriter xlwt odfpy +pyxlsb fastparquet>=0.4.0 pyarrow>=0.17.0 python-snappy From 6e635c3d8345aabf88e7f94d9b94b29a9b179c98 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Torsten=20W=C3=B6rtwein?= Date: Tue, 28 Sep 2021 22:38:11 -0400 Subject: [PATCH 4/7] from not as --- pandas/_libs/reshape.pyi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pandas/_libs/reshape.pyi b/pandas/_libs/reshape.pyi index 245f52c65100f..a4dea44aad7ad 100644 --- a/pandas/_libs/reshape.pyi +++ b/pandas/_libs/reshape.pyi @@ -1,6 +1,7 @@ import numpy as np -import pandas._typing as npt +from pandas._typing import npt + def unstack( values: np.ndarray, # reshape_t[:, :] From 504869cbe98705080e96096a155884c2c5bb9a9b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Torsten=20W=C3=B6rtwein?= Date: Tue, 28 Sep 2021 22:45:46 -0400 Subject: [PATCH 5/7] formatting --- pandas/_libs/reshape.pyi | 1 - 1 file changed, 1 deletion(-) diff --git a/pandas/_libs/reshape.pyi b/pandas/_libs/reshape.pyi index a4dea44aad7ad..110687fcd0c31 100644 --- a/pandas/_libs/reshape.pyi +++ b/pandas/_libs/reshape.pyi @@ -2,7 +2,6 @@ import numpy as np from pandas._typing import npt - def unstack( values: np.ndarray, # reshape_t[:, :] mask: np.ndarray, # const uint8_t[:] From 860bd16a0d0f50766437472691b45cd03f68ca9c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Torsten=20W=C3=B6rtwein?= Date: Wed, 29 Sep 2021 09:03:52 -0400 Subject: [PATCH 6/7] exclude clipboard (vendored) and enable reportMissingImports --- pyproject.toml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 0223a1c035cbc..fe48a4d684cf8 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -159,14 +159,13 @@ skip = "pandas/__init__.py" pythonVersion = "3.8" typeCheckingMode = "strict" include = ["pandas"] -exclude = ["pandas/tests", "pandas/util/version"] +exclude = ["pandas/tests", "pandas/io/clipboard", "pandas/util/version"] reportGeneralTypeIssues = false reportConstantRedefinition = false reportFunctionMemberAccess = false reportImportCycles = false reportIncompatibleMethodOverride = false reportIncompatibleVariableOverride = false -reportMissingImports = false reportMissingModuleSource = false reportMissingTypeArgument = false reportMissingTypeStubs = false From d163bd09a1104861a54d922979786a6b432d5e28 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Torsten=20W=C3=B6rtwein?= Date: Tue, 5 Oct 2021 09:31:58 -0400 Subject: [PATCH 7/7] use pyright comment instead of installing pyxlsb --- environment.yml | 1 - pandas/io/excel/_pyxlsb.py | 1 + requirements-dev.txt | 1 - 3 files changed, 1 insertion(+), 2 deletions(-) diff --git a/environment.yml b/environment.yml index 0c42876e673a3..1cd1179fc29b0 100644 --- a/environment.yml +++ b/environment.yml @@ -98,7 +98,6 @@ dependencies: - xlsxwriter - xlwt - odfpy - - pyxlsb - fastparquet>=0.4.0 # pandas.read_parquet, DataFrame.to_parquet - pyarrow>=0.17.0 # pandas.read_parquet, DataFrame.to_parquet, pandas.read_feather, DataFrame.to_feather diff --git a/pandas/io/excel/_pyxlsb.py b/pandas/io/excel/_pyxlsb.py index 52a67336aaa82..4b2b9f7a3a678 100644 --- a/pandas/io/excel/_pyxlsb.py +++ b/pandas/io/excel/_pyxlsb.py @@ -1,3 +1,4 @@ +# pyright: reportMissingImports=false from __future__ import annotations from pandas._typing import ( diff --git a/requirements-dev.txt b/requirements-dev.txt index 6b09f0c997eb4..14b9ac8a9393e 100644 --- a/requirements-dev.txt +++ b/requirements-dev.txt @@ -64,7 +64,6 @@ xlrd xlsxwriter xlwt odfpy -pyxlsb fastparquet>=0.4.0 pyarrow>=0.17.0 python-snappy