From 8fce2a26d9110935fb8a775c41c43c386e4d70aa Mon Sep 17 00:00:00 2001 From: Giacomo Caria Date: Wed, 4 Aug 2021 23:22:45 +0200 Subject: [PATCH 1/5] Add test --- pandas/tests/frame/test_constructors.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pandas/tests/frame/test_constructors.py b/pandas/tests/frame/test_constructors.py index 3c1614ac9f153..b0e577955529a 100644 --- a/pandas/tests/frame/test_constructors.py +++ b/pandas/tests/frame/test_constructors.py @@ -1203,6 +1203,12 @@ def test_constructor_DataFrame(self, float_frame): df_casted = DataFrame(float_frame, dtype=np.int64) assert df_casted.values.dtype == np.int64 + def test_constructor_empty_DataFrame(self): + + actual = pd.DataFrame(pd.DataFrame(), dtype="object") + expected = pd.DataFrame([], dtype="object") + tm.assert_frame_equal(actual, expected) + def test_constructor_more(self, float_frame): # used to be in test_matrix.py arr = np.random.randn(10) From 321125228a81e32dc5352a32fdab4914571b09b7 Mon Sep 17 00:00:00 2001 From: Jeff Reback Date: Wed, 4 Aug 2021 18:22:07 -0400 Subject: [PATCH 2/5] Update pandas/tests/frame/test_constructors.py --- pandas/tests/frame/test_constructors.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/tests/frame/test_constructors.py b/pandas/tests/frame/test_constructors.py index b0e577955529a..4852cece1a15b 100644 --- a/pandas/tests/frame/test_constructors.py +++ b/pandas/tests/frame/test_constructors.py @@ -1204,7 +1204,7 @@ def test_constructor_DataFrame(self, float_frame): assert df_casted.values.dtype == np.int64 def test_constructor_empty_DataFrame(self): - +# GH 20624 actual = pd.DataFrame(pd.DataFrame(), dtype="object") expected = pd.DataFrame([], dtype="object") tm.assert_frame_equal(actual, expected) From 2e48d2882b5dc56b5703a1f4f7bd44dd1f1d2368 Mon Sep 17 00:00:00 2001 From: Jeff Reback Date: Wed, 4 Aug 2021 18:22:38 -0400 Subject: [PATCH 3/5] Update pandas/tests/frame/test_constructors.py --- pandas/tests/frame/test_constructors.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/tests/frame/test_constructors.py b/pandas/tests/frame/test_constructors.py index 4852cece1a15b..197a97660bf03 100644 --- a/pandas/tests/frame/test_constructors.py +++ b/pandas/tests/frame/test_constructors.py @@ -1204,7 +1204,7 @@ def test_constructor_DataFrame(self, float_frame): assert df_casted.values.dtype == np.int64 def test_constructor_empty_DataFrame(self): -# GH 20624 + # GH 20624 actual = pd.DataFrame(pd.DataFrame(), dtype="object") expected = pd.DataFrame([], dtype="object") tm.assert_frame_equal(actual, expected) From e0adf7db3966e68315445e8f6f96c7cd9c64d24e Mon Sep 17 00:00:00 2001 From: Jeff Reback Date: Wed, 4 Aug 2021 18:23:05 -0400 Subject: [PATCH 4/5] Update pandas/tests/frame/test_constructors.py --- pandas/tests/frame/test_constructors.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/tests/frame/test_constructors.py b/pandas/tests/frame/test_constructors.py index 197a97660bf03..f3cd0a5b82801 100644 --- a/pandas/tests/frame/test_constructors.py +++ b/pandas/tests/frame/test_constructors.py @@ -1203,7 +1203,7 @@ def test_constructor_DataFrame(self, float_frame): df_casted = DataFrame(float_frame, dtype=np.int64) assert df_casted.values.dtype == np.int64 - def test_constructor_empty_DataFrame(self): + def test_constructor_empty_dataframe(self): # GH 20624 actual = pd.DataFrame(pd.DataFrame(), dtype="object") expected = pd.DataFrame([], dtype="object") From 4e4869a8193590c318cec304a76504baf0397f9e Mon Sep 17 00:00:00 2001 From: Giacomo Caria Date: Thu, 5 Aug 2021 09:35:04 +0200 Subject: [PATCH 5/5] Remove unnecessary module abbreviation --- pandas/tests/frame/test_constructors.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pandas/tests/frame/test_constructors.py b/pandas/tests/frame/test_constructors.py index f3cd0a5b82801..23d24e2f3cecb 100644 --- a/pandas/tests/frame/test_constructors.py +++ b/pandas/tests/frame/test_constructors.py @@ -1205,8 +1205,8 @@ def test_constructor_DataFrame(self, float_frame): def test_constructor_empty_dataframe(self): # GH 20624 - actual = pd.DataFrame(pd.DataFrame(), dtype="object") - expected = pd.DataFrame([], dtype="object") + actual = DataFrame(DataFrame(), dtype="object") + expected = DataFrame([], dtype="object") tm.assert_frame_equal(actual, expected) def test_constructor_more(self, float_frame):