From 36eb916d5aed12dc027e1ad4df6cb6478329a9e4 Mon Sep 17 00:00:00 2001 From: Matthew Zeitlin Date: Sun, 25 Jul 2021 11:59:39 -0400 Subject: [PATCH 1/4] PERF/REGR: masked isin slowdown --- pandas/core/arrays/masked.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/core/arrays/masked.py b/pandas/core/arrays/masked.py index 3a152bd5889b7..1d78a74db98f0 100644 --- a/pandas/core/arrays/masked.py +++ b/pandas/core/arrays/masked.py @@ -417,7 +417,7 @@ def isin(self, values) -> BooleanArray: # type: ignore[override] # see https://github.com/pandas-dev/pandas/pull/38379 for some discussion result[self._mask] = values_have_NA - mask = np.zeros_like(self, dtype=bool) + mask = np.zeros(self._data.shape, dtype=bool) return BooleanArray(result, mask, copy=False) def copy(self: BaseMaskedArrayT) -> BaseMaskedArrayT: From d233608a229b0ebfd4b7f4dc5c0f3c743679239d Mon Sep 17 00:00:00 2001 From: Matthew Zeitlin Date: Sun, 25 Jul 2021 12:12:27 -0400 Subject: [PATCH 2/4] Add whatsnew --- doc/source/whatsnew/v1.3.2.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/source/whatsnew/v1.3.2.rst b/doc/source/whatsnew/v1.3.2.rst index b136d6207681b..378f93f35d217 100644 --- a/doc/source/whatsnew/v1.3.2.rst +++ b/doc/source/whatsnew/v1.3.2.rst @@ -14,7 +14,7 @@ including other versions of pandas. Fixed regressions ~~~~~~~~~~~~~~~~~ -- +- Performance regression in :meth:`DataFrame.isin` and :meth:`Series.isin` for nullable data types (:issue:`42708`) - .. --------------------------------------------------------------------------- From 5ef6648a8ac7672b91d48e991f45e913b62ac062 Mon Sep 17 00:00:00 2001 From: Matthew Zeitlin Date: Sun, 25 Jul 2021 15:07:04 -0400 Subject: [PATCH 3/4] One more newline in whatsnew --- doc/source/whatsnew/v1.3.2.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/source/whatsnew/v1.3.2.rst b/doc/source/whatsnew/v1.3.2.rst index 378f93f35d217..400c1e5bbf23d 100644 --- a/doc/source/whatsnew/v1.3.2.rst +++ b/doc/source/whatsnew/v1.3.2.rst @@ -16,6 +16,7 @@ Fixed regressions ~~~~~~~~~~~~~~~~~ - Performance regression in :meth:`DataFrame.isin` and :meth:`Series.isin` for nullable data types (:issue:`42708`) - +- .. --------------------------------------------------------------------------- From 324554c5b8840d1060db99ff9bd6ad8218ab1ae2 Mon Sep 17 00:00:00 2001 From: Matthew Zeitlin Date: Mon, 26 Jul 2021 09:04:18 -0400 Subject: [PATCH 4/4] Change whatsnew ref to pr --- doc/source/whatsnew/v1.3.2.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/source/whatsnew/v1.3.2.rst b/doc/source/whatsnew/v1.3.2.rst index 400c1e5bbf23d..0cef77a5150f6 100644 --- a/doc/source/whatsnew/v1.3.2.rst +++ b/doc/source/whatsnew/v1.3.2.rst @@ -14,7 +14,7 @@ including other versions of pandas. Fixed regressions ~~~~~~~~~~~~~~~~~ -- Performance regression in :meth:`DataFrame.isin` and :meth:`Series.isin` for nullable data types (:issue:`42708`) +- Performance regression in :meth:`DataFrame.isin` and :meth:`Series.isin` for nullable data types (:issue:`42714`) - -