From c17aacc5f7009cd252eba1346d7d442ff887b2fa Mon Sep 17 00:00:00 2001 From: zeitlinv Date: Wed, 21 Jul 2021 21:14:11 -0400 Subject: [PATCH 1/2] TST: GH: 26861 --- pandas/tests/frame/indexing/test_setitem.py | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/pandas/tests/frame/indexing/test_setitem.py b/pandas/tests/frame/indexing/test_setitem.py index 25682330fe19a..08c3b14f49fe4 100644 --- a/pandas/tests/frame/indexing/test_setitem.py +++ b/pandas/tests/frame/indexing/test_setitem.py @@ -179,6 +179,19 @@ def test_setitem_with_unaligned_sparse_value(self): expected = Series(SparseArray([1, 0, 0]), name="new_column") tm.assert_series_equal(df["new_column"], expected) + def test_setitem_period_preserves_dtype(self): + # GH: 26861 + data = [Period("2003-12", "D")] + result = DataFrame([]) + result["a"] = data + result_dtype = result["a"].dtype + + expected = DataFrame({"a": data}) + expected_dtype = PeriodDtype(freq="D") + + assert result_dtype == expected_dtype + tm.assert_frame_equal(result, expected) + def test_setitem_dict_preserves_dtypes(self): # https://github.com/pandas-dev/pandas/issues/34573 expected = DataFrame( From 224f207040208c5565a17da414bc9fe8410240f9 Mon Sep 17 00:00:00 2001 From: zeitlinv Date: Thu, 22 Jul 2021 19:23:28 -0400 Subject: [PATCH 2/2] Removed dtype assertion from test --- pandas/tests/frame/indexing/test_setitem.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/pandas/tests/frame/indexing/test_setitem.py b/pandas/tests/frame/indexing/test_setitem.py index 08c3b14f49fe4..1e23f7d61efde 100644 --- a/pandas/tests/frame/indexing/test_setitem.py +++ b/pandas/tests/frame/indexing/test_setitem.py @@ -184,12 +184,9 @@ def test_setitem_period_preserves_dtype(self): data = [Period("2003-12", "D")] result = DataFrame([]) result["a"] = data - result_dtype = result["a"].dtype expected = DataFrame({"a": data}) - expected_dtype = PeriodDtype(freq="D") - assert result_dtype == expected_dtype tm.assert_frame_equal(result, expected) def test_setitem_dict_preserves_dtypes(self):