Updated the return type section of to_datetime #42244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixed timezone inputs
mroeschke
reviewed
Jun 26, 2021
mroeschke
reviewed
Jun 26, 2021
pandas/core/tools/datetimes.py
Outdated
| @@ -765,6 +765,7 @@ def to_datetime( | |||
| - list-like: DatetimeIndex | |||
| - Series: Series of datetime64 dtype | |||
| - scalar: Timestamp | |||
| - list-like with mixed timezones: Index of object dtype | |||
There was a problem hiding this comment.
Actually on second thought might be better to combine with list-like: DatetimeIndex like
- Index:
- DatetimeIndex if timezone naive or aware with the same timezone
- Index of object dtype if timezone aware with mixed timezones
|
@mroeschke - updated as per you suggestion |
mroeschke
reviewed
Jun 27, 2021
pandas/core/tools/datetimes.py
Outdated
| - Series: Series of datetime64 dtype | ||
| - scalar: Timestamp | ||
|
|
||
|
|
There was a problem hiding this comment.
Nit: Could you remove this newline?
mroeschke
reviewed
Jun 27, 2021
|
Removed the additional line , Thanks for patience and feedback @mroeschke |
mroeschke
approved these changes
Jun 27, 2021
3 tasks
smarie
reviewed
Jun 28, 2021
| @@ -762,7 +762,9 @@ def to_datetime( | |||
| If parsing succeeded. | |||
| Return type depends on input: | |||
|
|
|||
| - list-like: DatetimeIndex | |||
| - list-like: | |||
| - DatetimeIndex, if timezone naive or aware with the same timezone | |||
There was a problem hiding this comment.
As discussed in #42229 (comment)
Suggested change
| - DatetimeIndex, if timezone naive or aware with the same timezone | |
| - DatetimeIndex, if timezone naive or aware with the same time offset |
smarie
reviewed
Jun 28, 2021
Co-authored-by: Sylvain Marié <sylvain.marie@schneider-electric.com>
|
Thanks @prabha-git |
smarie
added a commit
to smarie/pandas
that referenced
this pull request
Jul 12, 2021
Following pandas-dev#42244 , improved documentation about datetime parsing. See also pandas-dev#42229 (comment)
1 task
|
Hi @prabha-git and @mroeschke ! It seems that the resulting comment is half/half (half speaking about timezone, half speaking about time offset...). Therefore I created #42494 to complete this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the return type section of to_datetime to include list-like mixed timezone inputs