From e019784bba7a5219ab4d0c539cc77d9ad9663811 Mon Sep 17 00:00:00 2001 From: jbrockmendel Date: Tue, 28 Apr 2020 20:40:43 -0700 Subject: [PATCH] TST: stop skipping Categorical take tests --- pandas/tests/extension/test_categorical.py | 39 ---------------------- 1 file changed, 39 deletions(-) diff --git a/pandas/tests/extension/test_categorical.py b/pandas/tests/extension/test_categorical.py index 059d3453995bd..390c7a2afc641 100644 --- a/pandas/tests/extension/test_categorical.py +++ b/pandas/tests/extension/test_categorical.py @@ -97,8 +97,6 @@ class TestReshaping(base.BaseReshapingTests): class TestGetitem(base.BaseGetitemTests): - skip_take = pytest.mark.skip(reason="GH-20664.") - @pytest.mark.skip(reason="Backwards compatibility") def test_getitem_scalar(self, data): # CategoricalDtype.type isn't "correct" since it should @@ -106,43 +104,6 @@ def test_getitem_scalar(self, data): # to break things by changing. super().test_getitem_scalar(data) - @skip_take - def test_take(self, data, na_value, na_cmp): - # TODO remove this once Categorical.take is fixed - super().test_take(data, na_value, na_cmp) - - @skip_take - def test_take_negative(self, data): - super().test_take_negative(data) - - @skip_take - def test_take_pandas_style_negative_raises(self, data, na_value): - super().test_take_pandas_style_negative_raises(data, na_value) - - @skip_take - def test_take_non_na_fill_value(self, data_missing): - super().test_take_non_na_fill_value(data_missing) - - @skip_take - def test_take_out_of_bounds_raises(self, data, allow_fill): - return super().test_take_out_of_bounds_raises(data, allow_fill) - - @pytest.mark.skip(reason="GH-20747. Unobserved categories.") - def test_take_series(self, data): - super().test_take_series(data) - - @skip_take - def test_reindex_non_na_fill_value(self, data_missing): - super().test_reindex_non_na_fill_value(data_missing) - - @pytest.mark.skip(reason="Categorical.take buggy") - def test_take_empty(self, data, na_value, na_cmp): - super().test_take_empty(data, na_value, na_cmp) - - @pytest.mark.skip(reason="test not written correctly for categorical") - def test_reindex(self, data, na_value): - super().test_reindex(data, na_value) - class TestSetitem(base.BaseSetitemTests): pass