From f6509c9c281df15b6e8cad4dd3aad28a0de89ca8 Mon Sep 17 00:00:00 2001 From: Will Ayd Date: Mon, 28 Oct 2019 12:42:42 -0700 Subject: [PATCH 1/5] Added whatsnew --- doc/source/whatsnew/v1.0.0.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/source/whatsnew/v1.0.0.rst b/doc/source/whatsnew/v1.0.0.rst index 4007ecd5a9412..60f69b076234f 100644 --- a/doc/source/whatsnew/v1.0.0.rst +++ b/doc/source/whatsnew/v1.0.0.rst @@ -226,6 +226,8 @@ with migrating existing code. Removal of prior version deprecations/changes ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +- Removed the previously deprecated ``raise_with_traceback`` function in ``pandas.compat`` (:issue:`2917`) + .. _whatsnew_1000.matplotlib_units: **Matplotlib unit registration** From 36aea70c930d965d448fb436d0ec7b73d981fe34 Mon Sep 17 00:00:00 2001 From: Will Ayd Date: Mon, 28 Oct 2019 12:43:39 -0700 Subject: [PATCH 2/5] typo --- doc/source/whatsnew/v1.0.0.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/source/whatsnew/v1.0.0.rst b/doc/source/whatsnew/v1.0.0.rst index 60f69b076234f..1c0a2e2b5e356 100644 --- a/doc/source/whatsnew/v1.0.0.rst +++ b/doc/source/whatsnew/v1.0.0.rst @@ -226,7 +226,7 @@ with migrating existing code. Removal of prior version deprecations/changes ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -- Removed the previously deprecated ``raise_with_traceback`` function in ``pandas.compat`` (:issue:`2917`) +- Removed the previously deprecated ``raise_with_traceback`` function in ``pandas.compat`` (:issue:`29174`) .. _whatsnew_1000.matplotlib_units: From b32257e31fe0f3eccde3d2de1b071cdc392c99d2 Mon Sep 17 00:00:00 2001 From: Will Ayd Date: Mon, 28 Oct 2019 13:42:16 -0700 Subject: [PATCH 3/5] Fixed note --- doc/source/whatsnew/v1.0.0.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/source/whatsnew/v1.0.0.rst b/doc/source/whatsnew/v1.0.0.rst index 1c0a2e2b5e356..d2402b1144d3d 100644 --- a/doc/source/whatsnew/v1.0.0.rst +++ b/doc/source/whatsnew/v1.0.0.rst @@ -226,7 +226,7 @@ with migrating existing code. Removal of prior version deprecations/changes ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -- Removed the previously deprecated ``raise_with_traceback`` function in ``pandas.compat`` (:issue:`29174`) +- Removed the previously deprecated ``assert_raises_regex`` function in ``pandas.util.testing`` (:issue:`29174`) .. _whatsnew_1000.matplotlib_units: From ff67248a01b018ffeab813f2ea875a5c1c8af513 Mon Sep 17 00:00:00 2001 From: Will Ayd Date: Mon, 28 Oct 2019 13:42:42 -0700 Subject: [PATCH 4/5] removed code check --- ci/code_checks.sh | 4 ---- 1 file changed, 4 deletions(-) diff --git a/ci/code_checks.sh b/ci/code_checks.sh index f4761c5663c9f..f704a1018c926 100755 --- a/ci/code_checks.sh +++ b/ci/code_checks.sh @@ -171,10 +171,6 @@ if [[ -z "$CHECK" || "$CHECK" == "patterns" ]]; then invgrep -R --include="*.py" --include="*.pyx" --include="*.rst" -E "\.\. (autosummary|contents|currentmodule|deprecated|function|image|important|include|ipython|literalinclude|math|module|note|raw|seealso|toctree|versionadded|versionchanged|warning):[^:]" ./pandas ./doc/source RET=$(($RET + $?)) ; echo $MSG "DONE" - MSG='Check that the deprecated `assert_raises_regex` is not used (`pytest.raises(match=pattern)` should be used instead)' ; echo $MSG - invgrep -R --exclude=*.pyc --exclude=testing.py --exclude=test_util.py assert_raises_regex pandas - RET=$(($RET + $?)) ; echo $MSG "DONE" - # Check for the following code in testing: `unittest.mock`, `mock.Mock()` or `mock.patch` MSG='Check that unittest.mock is not used (pytest builtin monkeypatch fixture should be used instead)' ; echo $MSG invgrep -r -E --include '*.py' '(unittest(\.| import )mock|mock\.Mock\(\)|mock\.patch)' pandas/tests/ From 4aaf37746a143ad5e0682f6c3313f64c1cc1ed9d Mon Sep 17 00:00:00 2001 From: Will Ayd Date: Tue, 29 Oct 2019 09:09:36 -0700 Subject: [PATCH 5/5] moved note --- doc/source/whatsnew/v1.0.0.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/doc/source/whatsnew/v1.0.0.rst b/doc/source/whatsnew/v1.0.0.rst index d2402b1144d3d..5e16cee1de89c 100644 --- a/doc/source/whatsnew/v1.0.0.rst +++ b/doc/source/whatsnew/v1.0.0.rst @@ -226,8 +226,6 @@ with migrating existing code. Removal of prior version deprecations/changes ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -- Removed the previously deprecated ``assert_raises_regex`` function in ``pandas.util.testing`` (:issue:`29174`) - .. _whatsnew_1000.matplotlib_units: **Matplotlib unit registration** @@ -257,6 +255,7 @@ or ``matplotlib.Axes.plot``. See :ref:`plotting.formatters` for more. - Removed the previously deprecated ``IntervalIndex.from_intervals`` in favor of the :class:`IntervalIndex` constructor (:issue:`19263`) - Ability to read pickles containing :class:`Categorical` instances created with pre-0.16 version of pandas has been removed (:issue:`27538`) - Removed the previously deprecated ``reduce`` and ``broadcast`` arguments from :meth:`DataFrame.apply` (:issue:`18577`) +- Removed the previously deprecated ``assert_raises_regex`` function in ``pandas.util.testing`` (:issue:`29174`) - .. _whatsnew_1000.performance: