From 8ac8aa8f16e7b555dadf9a5493cb07e43f454448 Mon Sep 17 00:00:00 2001
From: Max Chen <immaxchen@gmail.com>
Date: Wed, 16 Oct 2019 00:58:17 +0800
Subject: [PATCH] CLN: Fix mypy error in pandas/tests/computation/test_eval.py

Added explicit typing annotation for _parsers: Dict[str, Type[BaseExprVisitor]]
Also added some import for Dict, Type and BaseExprVisitor
---
 pandas/tests/computation/test_eval.py | 9 +++++++--
 setup.cfg                             | 3 ---
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/pandas/tests/computation/test_eval.py b/pandas/tests/computation/test_eval.py
index b6ffd8a83e409..4d40cd3a2d4ca 100644
--- a/pandas/tests/computation/test_eval.py
+++ b/pandas/tests/computation/test_eval.py
@@ -2,6 +2,7 @@
 from functools import reduce
 from itertools import product
 import operator
+from typing import Dict, Type
 import warnings
 
 import numpy as np
@@ -19,7 +20,11 @@
 from pandas.core.computation.check import _NUMEXPR_VERSION
 from pandas.core.computation.engines import NumExprClobberingError, _engines
 import pandas.core.computation.expr as expr
-from pandas.core.computation.expr import PandasExprVisitor, PythonExprVisitor
+from pandas.core.computation.expr import (
+    BaseExprVisitor,
+    PandasExprVisitor,
+    PythonExprVisitor,
+)
 from pandas.core.computation.expressions import _NUMEXPR_INSTALLED, _USE_NUMEXPR
 from pandas.core.computation.ops import (
     _arith_ops_syms,
@@ -1884,7 +1889,7 @@ def test_invalid_parser():
     "python": PythonExprVisitor,
     "pytables": pytables.ExprVisitor,
     "pandas": PandasExprVisitor,
-}
+}  # type: Dict[str, Type[BaseExprVisitor]]
 
 
 @pytest.mark.parametrize("engine", _engines)
diff --git a/setup.cfg b/setup.cfg
index 55d25abde585c..9047261908c9b 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -145,9 +145,6 @@ ignore_errors=True
 [mypy-pandas.tests.arrays.test_period]
 ignore_errors=True
 
-[mypy-pandas.tests.computation.test_eval]
-ignore_errors=True
-
 [mypy-pandas.tests.dtypes.test_common]
 ignore_errors=True