From f6bd584c4b74f0a6fcb449ffe425e845443e1e2e Mon Sep 17 00:00:00 2001 From: gfyoung Date: Tue, 21 Mar 2017 13:55:40 -0400 Subject: [PATCH] DOC: Ensure basic flake8 diff checks only Python Follow-up to gh-15749 --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- doc/source/contributing.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 918d427ee4f4c..9281c51059087 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ - [ ] closes #xxxx - [ ] tests added / passed - - [ ] passes ``git diff upstream/master | flake8 --diff`` + - [ ] passes ``git diff upstream/master --name-only -- '*.py' | flake8 --diff`` - [ ] whatsnew entry diff --git a/doc/source/contributing.rst b/doc/source/contributing.rst index 7ad5916a8809d..5e551a7fd5349 100644 --- a/doc/source/contributing.rst +++ b/doc/source/contributing.rst @@ -518,7 +518,7 @@ Travis-CI will run the `flake8 `_ tool and report any stylistic errors in your code. Therefore, it is helpful before submitting code to run the check yourself on the diff:: - git diff master | flake8 --diff + git diff master --name-only -- '*.py' | flake8 --diff This command will catch any stylistic errors in your changes specifically, but be beware it may not catch all of them. For example, if you delete the only