Skip to content

BUG: Fix na_rep when using pd.NA in _format_strings (#33950) #34565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1,025 commits into from
Closed

BUG: Fix na_rep when using pd.NA in _format_strings (#33950) #34565

wants to merge 1,025 commits into from

Conversation

k-fillmore
Copy link

@k-fillmore k-fillmore commented Jun 4, 2020 •
edited
Loading

@k-fillmore k-fillmore changed the title add support for na_rep when using pd.NA in _format_strings See #33950 BUG: Add support for na_rep when using pd.NA in _format_strings (#33950) Jun 4, 2020
@k-fillmore k-fillmore changed the title BUG: Add support for na_rep when using pd.NA in _format_strings (#33950) BUG: Fix na_rep when using pd.NA in _format_strings (#33950) Jun 4, 2020
@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Jun 4, 2020 •
edited
Loading

@k-fillmore thanks for the contribution!

Does this keep the correct "<NA>" representation by default? (when not using na_rep keyword)

Further, can you add a test for this?

@jorisvandenbossche jorisvandenbossche added IO HTML read_html, to_html, Styler.apply, Styler.applymap Output-Formatting __repr__ of pandas objects, to_string labels Jun 4, 2020
@k-fillmore
Copy link
Author

Hi, @jorisvandenbossche Doesn't appear to retain the "" representation. I've added an additional expression to address this. Working on tests.

@pep8speaks
Copy link

pep8speaks commented Jun 5, 2020 •
edited
Loading

Hello @k-fillmore! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-05 22:52:41 UTC

@k-fillmore
Copy link
Author

@jorisvandenbossche added tests. Don't really like the leading whitespace that I had to add. But that's how they're being passed back from GenericArrayFormatter. I tried to track down where they're coming from but didnt have much luck. Any ideas?

@k-fillmore
Copy link
Author

Just want to follow up on this. Do I need to add anything else?

@TomAugspurger
Copy link
Contributor

#33950 (comment) noted that this affects NaT too. Can you fix that here or open a second issue?

@TomAugspurger
Copy link
Contributor

Can you also merge master and re-push. I don't know why CI failed last time. We also need a release note in whatsnew/1.2.0.rst.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2020

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Oct 5, 2020
@k-fillmore
Copy link
Author

Noted, working on NaT here. Will do a merge master and add change logs as requested.

rxxg and others added 16 commits October 5, 2020 18:59
@rxxg
Ensure resource closure in all exceptional circumstances during const…
d6ae841 
…ruction (#35566) (#35587)
@Dr-Irv
Change default of float_precision for read_csv and read_table to "hig…
6b8131f 
…h" (#36228)
@asishm
BUG: read_excel for ods files raising UnboundLocalError in certain ca…
4ae3c68 
…ses (#36175)
@alexhtn
DOC: add type BinaryIO to path param #35505 (#35568)
4b16138
@arw2019
DOC: update DataFrame.to_feather docstring (#35408)
d5df269
@phofl
Concatenating rows with Int64 datatype coerces to object
bec46e0
@jbrockmendel
REF: use check_setitem_lengths in DTA.__setitem__ (#36339)
32e4413
DOC: Added docstring for storage_options for read_csv GH36361 (#36364)
2096dfd 
* Update parsers.py

DOC: Added docstring for storage_options GH36361

* Update parsers.py

DOC: Added docstring for storage_options GH36361

* Update parsers.py

removed trailing whitespace
@jbrockmendel
REF: _unbox_scalar, _unbox_listlike for Categorical (#36362)
88c3a1b
@jbrockmendel
REF: _assert_can_do_op -> _validate_scalar (#36367)
5d8009a
@jbrockmendel
REF: share code for __setitem__ (#36366)
7fe631e
@dsaxton
CI: Add stale PR action (#36336)
84a416b
@fangchenli
BUG: add py39 compat check for ast.slice #32766 (#36080)
d5f00bb
@fangchenli
Move sort index to generic (#36177)
ffb52d3
@phofl
[BUG]: Implement Kahan summation for rolling().mean() to avoid numeri…
3943050 
…cal issues (#36348)
@erfannariman
DOC: Example for natural sort using key argument (#36356)
e4c8e3c
dsaxton and others added 27 commits October 5, 2020 18:59
@dsaxton
ENH: Implement FloatingArray reductions (#36778)
a3f3f9f
@phofl
[BUG]: Rolling selected too large windows with PeriodIndex (#36730)
ed477e6
@karasinski
DOC: update code style for development doc and user guide #36777 (#36821
7cdf0ef 
)
@karasinski
DOC: update code style for user guide for #36777 (#36823)
b9e7204
@PrayagS
DOC: use black to fix code style in doc #36777 (#36824)
5ca19f8
@erfannariman
CI: silence codecov for unrelated lines (#36600)
3408b0d
@erfannariman
DOC: reformat doc groupby.rst (#36831)
a684ec1
@fokoid
TST: GH23452 test reorder_categories() on categorical index (#36648)
9fa1417
@lrjball
Typo fix (#36844)
ded52b0 
Noticed a minor typo when using the docs
@ivanovmg
CLN: private funcs in concat.py (#36726)
d4b98de 
* REF: extract func _select_upcast_cls_from_dtype

* REF: extract function _get_upcast_classes

* CLN: rename g -> common_dtype

* TYP: type extracted functions

* DOC: add docstrings to extracted methods

* TYP: cast instead of ignoring mypy error

* CLN: import SparseDtype only for type checking
@jbrockmendel @jreback
ENH: match stdlib behavior for datetimelike comparisons (#36647)
2f24cc2 
* ENH: match stdlib behavior for datetimelike comparisons

* update test

Co-authored-by: Jeff Reback <jeff@reback.net>
@meghanacosmos
doc/source/ecosystem.rst (#36856)
2745a4e
DOC: black enhancingperf.rst and 10min.rst code style (#36849)
3b0b51b
@LeviMatus
DOC: normalize usage of word "pandas" (#36845)
08c312b
@simonjayhawkins
TYP: update setup.cfg (#36854)
40f81a8
@dsaxton
CI: Update error message for np_dev (#36864)
7c3fac4 
* CI: Update error message for np_dev

* Comma

* Fix
@maria-ilie
DOC: ran blacken docs tool and checked output to improve formatting #…
3262442 
…36777 (#36802)
CLN: Remove the duplicate configuration of flake8-rst in setup.cfg (#…
cd4a558 
…36877)
@Tazminia
upgrade flake8 to 3.8.4 (#36882)
51bf616
@meghanacosmos
DOC: doc/source/whatsnew (#36857)
c2a40bf
@simonjayhawkins
TYP: check_untyped_defs core.arrays.base (#36885)
ee917d0
@simonjayhawkins
TYP: check_untyped_defs compat.pickle_compat (#36884)
345aa61
@mroeschke
PERF: Improve RollingGroupby.count (#36872)
5e25a21
@simonjayhawkins
DOC: 1.1.3 release date (#36887)
ee436ad
@avinashpancham
Add asv benchmarks for select_dtypes (#36839)
b884267
@dsaxton
DOC: Start v1.1.4 release notes (#36689)
5f14ef7
@k-fillmore
add support for na_rep when using pd.NA in _format_strings See #33950
6ebc186
arw2019
arw2019 reviewed Oct 31, 2020
View reviewed changes
Copy link
Member

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k-fillmore are you interested in continuing? If yes merge master (looks like you have merge issues atm) and we'll take another look

@arw2019
Copy link
Member

arw2019 commented Nov 4, 2020

Closing for now. @k-fillmore let us know whenever you'd like to continue and we'll reopen!

@arw2019 arw2019 closed this Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arw2019 arw2019 arw2019 left review comments

Assignees
No one assigned
Labels
IO HTML read_html, to_html, Styler.apply, Styler.applymap Output-Formatting __repr__ of pandas objects, to_string Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: pd.NA ignored in DataFrame.to_html(na_rep)