Skip to content

Commit f9b0b49

Browse files
committed
Handle get_values, to_dense, is_view
1 parent 240e8f6 commit f9b0b49

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

pandas/core/internals.py

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1814,6 +1814,11 @@ def __init__(self, values, placement, ndim=None):
18141814
self._holder = type(values)
18151815
super(ExtensionBlock, self).__init__(values, placement, ndim=ndim)
18161816

1817+
@property
1818+
def is_view(self):
1819+
"""Extension arrays are never treated as views."""
1820+
return False
1821+
18171822
def get_values(self, dtype=None):
18181823
# ExtensionArrays must be iterable, so this works.
18191824
values = np.asarray(self.values)
@@ -1822,7 +1827,7 @@ def get_values(self, dtype=None):
18221827
return values
18231828

18241829
def to_dense(self):
1825-
return self.values.get_values()
1830+
return np.asarray(self.values)
18261831

18271832
def take_nd(self, indexer, axis=0, new_mgr_locs=None, fill_tuple=None):
18281833
"""
@@ -2412,12 +2417,6 @@ def __init__(self, values, placement, ndim=None):
24122417
super(CategoricalBlock, self).__init__(_maybe_to_categorical(values),
24132418
placement=placement,
24142419
ndim=ndim)
2415-
2416-
@property
2417-
def is_view(self):
2418-
""" I am never a view """
2419-
return False
2420-
24212420
@property
24222421
def array_dtype(self):
24232422
""" the dtype to return if I want to construct this block as an
@@ -2461,6 +2460,12 @@ def shift(self, periods, axis=0, mgr=None):
24612460
return self.make_block_same_class(values=self.values.shift(periods),
24622461
placement=self.mgr_locs)
24632462

2463+
def to_dense(self):
2464+
# Categorical.get_values returns a DatetimeIndex for datetime
2465+
# categories, so we can't simply use `np.asarray(self.values)` like
2466+
# other types.
2467+
return self.values.get_values()
2468+
24642469
def to_native_types(self, slicer=None, na_rep='', quoting=None, **kwargs):
24652470
""" convert to our native types format, slicing if desired """
24662471

0 commit comments

Comments
 (0)