Skip to content

Commit f9240b5

Browse files
committed
use kwargs to hide require_iso8601
1 parent 5dc7a37 commit f9240b5

File tree

3 files changed

+8
-13
lines changed

3 files changed

+8
-13
lines changed

pandas/core/dtypes/cast.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -916,7 +916,7 @@ def try_datetime(v):
916916
try:
917917
from pandas import to_datetime
918918
# GH19671
919-
return to_datetime(v, _require_iso8601=True)
919+
return to_datetime(v, require_iso8601=True)
920920
except Exception:
921921
pass
922922

pandas/core/tools/datetimes.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -106,16 +106,10 @@ def _convert_and_box_cache(arg, cache_array, box, errors, name=None):
106106
def to_datetime(arg, errors='raise', dayfirst=False, yearfirst=False,
107107
utc=None, box=True, format=None, exact=True,
108108
unit=None, infer_datetime_format=False, origin='unix',
109-
cache=False, _require_iso8601=False):
109+
cache=False, **kwargs):
110110
"""
111111
Convert argument to datetime.
112112
113-
Passing _require_iso8601=True will only parse datetime strings similar to
114-
`ISO8601 <https://en.wikipedia.org/wiki/ISO_8601>`_ and treat others as
115-
non-parseable dates.
116-
117-
.. versionadded:: 0.23.0
118-
119113
Parameters
120114
----------
121115
arg : integer, float, string, datetime, list, tuple, 1-d array, Series
@@ -278,9 +272,10 @@ def to_datetime(arg, errors='raise', dayfirst=False, yearfirst=False,
278272
from pandas.core.indexes.datetimes import DatetimeIndex
279273

280274
tz = 'utc' if utc else None
275+
require_iso8601 = kwargs.get('require_iso8601', None)
281276

282277
def _convert_listlike(arg, box, format, name=None, tz=tz,
283-
require_iso8601=_require_iso8601):
278+
require_iso8601=require_iso8601):
284279

285280
if isinstance(arg, (list, tuple)):
286281
arg = np.array(arg, dtype='O')

pandas/tests/indexes/datetimes/test_tools.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -471,15 +471,15 @@ def test_datetime_require_iso8601(self):
471471
# GH19671
472472
s = Series(['M1809', 'M1701', Timestamp('20130101')])
473473
with pytest.raises(ValueError):
474-
to_datetime(s, _require_iso8601=True, errors='raise')
474+
to_datetime(s, require_iso8601=True, errors='raise')
475475
tm.assert_series_equal(
476-
to_datetime(s, _require_iso8601=True, errors='ignore'),
476+
to_datetime(s, require_iso8601=True, errors='ignore'),
477477
Series(['M1809', 'M1701', Timestamp('20130101')]))
478478
tm.assert_series_equal(
479-
to_datetime(s, _require_iso8601=True, errors='coerce'),
479+
to_datetime(s, require_iso8601=True, errors='coerce'),
480480
Series([NaT, NaT, Timestamp('20130101')]))
481481
tm.assert_series_equal(
482-
to_datetime(s, _require_iso8601=False, errors='raise'),
482+
to_datetime(s, require_iso8601=False, errors='raise'),
483483
Series([Timestamp('18090101'), Timestamp('17010101'),
484484
Timestamp('20130101')]))
485485

0 commit comments

Comments
 (0)