Skip to content

Commit f350756

Browse files
committed
fix mypy errors
1 parent 9664d81 commit f350756

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

pandas/core/frame.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,12 +93,13 @@
9393
from pandas.core.dtypes.missing import isna, notna
9494

9595
from pandas._typing import Axes, Dtype, FilePathOrBuffer
96-
from pandas.core import algorithms, common as com, groupby, nanops, ops
96+
from pandas.core import algorithms, common as com, nanops, ops
9797
from pandas.core.accessor import CachedAccessor
9898
from pandas.core.arrays import Categorical, ExtensionArray
9999
from pandas.core.arrays.datetimelike import DatetimeLikeArrayMixin as DatetimeLikeArray
100100
from pandas.core.arrays.sparse import SparseFrameAccessor
101101
from pandas.core.generic import NDFrame, _shared_docs
102+
from pandas.core.groupby import generic as grp_generic
102103
from pandas.core.indexes import base as ibase
103104
from pandas.core.indexes.api import Index, ensure_index, ensure_index_from_sequences
104105
from pandas.core.indexes.datetimes import DatetimeIndex
@@ -5583,13 +5584,13 @@ def groupby(
55835584
group_keys: bool = True,
55845585
squeeze: bool = False,
55855586
observed: bool = False,
5586-
) -> "groupby.DataFrameGroupBy":
5587+
) -> "grp_generic.DataFrameGroupBy":
55875588

55885589
if level is None and by is None:
55895590
raise TypeError("You have to supply one of 'by' and 'level'")
55905591
axis = self._get_axis_number(axis)
55915592

5592-
return groupby.DataFrameGroupBy(
5593+
return grp_generic.DataFrameGroupBy(
55935594
obj=self,
55945595
keys=by,
55955596
axis=axis,

pandas/core/reshape/merge.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@
4141
from pandas.core.dtypes.missing import isna, na_value_for_dtype
4242

4343
from pandas import Categorical, Index, MultiIndex
44+
from pandas._typing import FrameOrSeries
45+
from pandas.core import groupby
4446
import pandas.core.algorithms as algos
4547
from pandas.core.arrays.categorical import _recode_for_categories
4648
import pandas.core.common as com
@@ -113,6 +115,7 @@ def _groupby_and_merge(
113115
by = [by]
114116

115117
lby = left.groupby(by, sort=False)
118+
rby: Optional[groupby.DataFrameGroupBy] = None
116119

117120
# if we can groupby the rhs
118121
# then we can get vastly better perf
@@ -132,7 +135,7 @@ def _groupby_and_merge(
132135
try:
133136
rby = right.groupby(by, sort=False)
134137
except KeyError:
135-
rby = None
138+
pass
136139

137140
for key, lhs in lby:
138141

pandas/core/series.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
)
4848

4949
import pandas as pd
50-
from pandas.core import algorithms, base, generic, groupby, nanops, ops
50+
from pandas.core import algorithms, base, generic, nanops, ops
5151
from pandas.core.accessor import CachedAccessor
5252
from pandas.core.arrays import ExtensionArray, try_cast_to_ea
5353
from pandas.core.arrays.categorical import Categorical, CategoricalAccessor
@@ -59,6 +59,7 @@
5959
is_empty_data,
6060
sanitize_array,
6161
)
62+
from pandas.core.groupby import generic as grp_generic
6263
from pandas.core.indexers import maybe_convert_indices
6364
from pandas.core.indexes.accessors import CombinedDatetimelikeProperties
6465
from pandas.core.indexes.api import (
@@ -1630,13 +1631,13 @@ def groupby(
16301631
group_keys: bool = True,
16311632
squeeze: bool = False,
16321633
observed: bool = False,
1633-
) -> "groupby.SeriesGroupBy":
1634+
) -> "grp_generic.SeriesGroupBy":
16341635

16351636
if level is None and by is None:
16361637
raise TypeError("You have to supply one of 'by' and 'level'")
16371638
axis = self._get_axis_number(axis)
16381639

1639-
return groupby.SeriesGroupBy(
1640+
return grp_generic.SeriesGroupBy(
16401641
obj=self,
16411642
keys=by,
16421643
axis=axis,

0 commit comments

Comments
 (0)