Skip to content

Commit ed257bb

Browse files
committed
POC: infer time objects to ArrowDtype[time]
1 parent 8bbb5cb commit ed257bb

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

pandas/_libs/lib.pyx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2644,7 +2644,6 @@ def maybe_convert_objects(ndarray[object] objects,
26442644

26452645
elif seen.time_:
26462646
if is_time_array(objects):
2647-
# FIXME: need to ensure this is not timetz
26482647
opt = get_option("future.infer_time")
26492648
if opt is True:
26502649
import pyarrow as pa

pandas/tests/io/test_sql.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2960,16 +2960,15 @@ def test_datetime_date(self):
29602960
def test_datetime_time(self, tz_aware):
29612961
# test support for datetime.time, GH #8341
29622962

2963+
warn_msg = "Pandas type inference with a sequence of `datetime.time`"
29632964
if not tz_aware:
29642965
tz_times = [time(9, 0, 0), time(9, 1, 30)]
2966+
warn = FutureWarning
29652967
else:
29662968
tz_dt = date_range("2013-01-01 09:00:00", periods=2, tz="US/Pacific")
29672969
tz_times = Series(tz_dt.to_pydatetime()).map(lambda dt: dt.timetz())
2970+
warn = None
29682971

2969-
warn_msg = "Pandas type inference with a sequence of `datetime.time`"
2970-
warn = None
2971-
if not tz_aware:
2972-
warn = FutureWarning
29732972
with tm.assert_produces_warning(warn, match=warn_msg):
29742973
df = DataFrame(tz_times, columns=["a"])
29752974

pandas/tests/series/accessors/test_dt_accessor.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ def get_expected(ser, prop):
101101
left = getattr(ser.dt, name)
102102
right = get_expected(ser, name)
103103

104+
104105
if not (is_list_like(left) and is_list_like(right)):
105106
assert left == right
106107
elif isinstance(left, DataFrame):

0 commit comments

Comments
 (0)