Skip to content

Commit e82c0c6

Browse files
authored
CLN: Pass numpy args as kwargs (#33789)
1 parent a7741e3 commit e82c0c6

File tree

2 files changed

+10
-27
lines changed

2 files changed

+10
-27
lines changed

pandas/compat/numpy/function.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,11 +251,16 @@ def validate_cum_func_with_skipna(skipna, args, kwargs, name):
251251
STAT_FUNC_DEFAULTS["dtype"] = None
252252
STAT_FUNC_DEFAULTS["out"] = None
253253

254-
PROD_DEFAULTS = SUM_DEFAULTS = STAT_FUNC_DEFAULTS.copy()
254+
SUM_DEFAULTS = STAT_FUNC_DEFAULTS.copy()
255255
SUM_DEFAULTS["axis"] = None
256256
SUM_DEFAULTS["keepdims"] = False
257257
SUM_DEFAULTS["initial"] = None
258258

259+
PROD_DEFAULTS = STAT_FUNC_DEFAULTS.copy()
260+
PROD_DEFAULTS["axis"] = None
261+
PROD_DEFAULTS["keepdims"] = False
262+
PROD_DEFAULTS["initial"] = None
263+
259264
MEDIAN_DEFAULTS = STAT_FUNC_DEFAULTS.copy()
260265
MEDIAN_DEFAULTS["overwrite_input"] = False
261266
MEDIAN_DEFAULTS["keepdims"] = False

pandas/core/arrays/numpy_.py

Lines changed: 4 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -365,36 +365,14 @@ def max(self, skipna: bool = True, **kwargs) -> Scalar:
365365
)
366366
return result
367367

368-
def sum(
369-
self,
370-
axis=None,
371-
dtype=None,
372-
out=None,
373-
keepdims=False,
374-
initial=None,
375-
skipna=True,
376-
min_count=0,
377-
):
378-
nv.validate_sum(
379-
(), dict(dtype=dtype, out=out, keepdims=keepdims, initial=initial)
380-
)
368+
def sum(self, axis=None, skipna=True, min_count=0, **kwargs) -> Scalar:
369+
nv.validate_sum((), kwargs)
381370
return nanops.nansum(
382371
self._ndarray, axis=axis, skipna=skipna, min_count=min_count
383372
)
384373

385-
def prod(
386-
self,
387-
axis=None,
388-
dtype=None,
389-
out=None,
390-
keepdims=False,
391-
initial=None,
392-
skipna=True,
393-
min_count=0,
394-
):
395-
nv.validate_prod(
396-
(), dict(dtype=dtype, out=out, keepdims=keepdims, initial=initial)
397-
)
374+
def prod(self, axis=None, skipna=True, min_count=0, **kwargs) -> Scalar:
375+
nv.validate_prod((), kwargs)
398376
return nanops.nanprod(
399377
self._ndarray, axis=axis, skipna=skipna, min_count=min_count
400378
)

0 commit comments

Comments
 (0)