STYLE enable pylint: subprocess-run-check (#49781)

* STYLE enable pylint: subprocess-run-check

* STYLE enable pylint: subprocess-run-check II

Author: natmokval

asv_bench/benchmarks/package.py

@@ -11,7 +11,7 @@ def time_import(self):
         #  measurement of the import time we actually care about,
         #  without the subprocess or interpreter overhead
         cmd = [sys.executable, "-X", "importtime", "-c", "import pandas as pd"]
-        p = subprocess.run(cmd, stderr=subprocess.PIPE)
+        p = subprocess.run(cmd, stderr=subprocess.PIPE, check=True)
 
         line = p.stderr.splitlines()[-1]
         field = line.split(b"|")[-2].strip()

pyproject.toml

@@ -146,7 +146,6 @@ disable = [
   "self-assigning-variable",
   "self-cls-assignment",
   "signature-differs",
-  "subprocess-run-check",
   "super-init-not-called",
   "try-except-raise",
   "undefined-loop-variable",

scripts/run_autotyping.py

@@ -28,6 +28,7 @@ def main(argv: Sequence[str] | None = None) -> None:
             *args.paths,
             "--aggressive",
         ],
+        check=True,
     )
     sys.exit(output.returncode)
 

scripts/validate_docstrings.py

@@ -211,7 +211,7 @@ def validate_pep8(self):
             file.write(content)
             file.flush()
             cmd = ["python", "-m", "flake8", "--quiet", "--statistics", file.name]
-            response = subprocess.run(cmd, capture_output=True, text=True)
+            response = subprocess.run(cmd, capture_output=True, check=False, text=True)
             stdout = response.stdout
             stdout = stdout.replace(file.name, "")
             messages = stdout.strip("\n")