BUG: Error reporting str.startswith and str.endswith (#45897)

* BUG: Error reporting str.startswith and str.endswith

Close #3485

* Bug: Explicit TypeError parameter in whatsnew

Author: NumberPiOso

doc/source/whatsnew/v1.5.0.rst

@@ -304,7 +304,7 @@ Conversion
 
 Strings
 ^^^^^^^
--
+- Bug in :meth:`str.startswith` and :meth:`str.endswith` when using other series as parameter _pat_. Now raises ``TypeError`` (:issue:`3485`)
 -
 
 Interval

pandas/core/strings/accessor.py

@@ -2282,6 +2282,9 @@ def startswith(self, pat, na=None):
         3    False
         dtype: bool
         """
+        if not isinstance(pat, str):
+            msg = f"expected a string object, not {type(pat).__name__}"
+            raise TypeError(msg)
         result = self._data.array._str_startswith(pat, na=na)
         return self._wrap_result(result, returns_string=False)
 
@@ -2339,6 +2342,9 @@ def endswith(self, pat, na=None):
         3    False
         dtype: bool
         """
+        if not isinstance(pat, str):
+            msg = f"expected a string object, not {type(pat).__name__}"
+            raise TypeError(msg)
         result = self._data.array._str_endswith(pat, na=na)
         return self._wrap_result(result, returns_string=False)
 

pandas/tests/strings/test_strings.py

@@ -16,6 +16,17 @@
 import pandas._testing as tm
 
 
+@pytest.mark.parametrize("pattern", [0, True, Series(["foo", "bar"])])
+def test_startswith_endswith_non_str_patterns(pattern):
+    # GH3485
+    ser = Series(["foo", "bar"])
+    msg = f"expected a string object, not {type(pattern).__name__}"
+    with pytest.raises(TypeError, match=msg):
+        ser.str.startswith(pattern)
+    with pytest.raises(TypeError, match=msg):
+        ser.str.endswith(pattern)
+
+
 def assert_series_or_index_equal(left, right):
     if isinstance(left, Series):
         tm.assert_series_equal(left, right)