Share declaration

Author: TomAugspurger

pandas/_libs/parsers.pyx

@@ -1331,8 +1331,8 @@ cdef class TextReader:
                 return None
 
 
-cdef object _true_values = [b'True', b'TRUE', b'true']
-cdef object _false_values = [b'False', b'FALSE', b'false']
+_true_values = [b'True', b'TRUE', b'true']
+_false_values = [b'False', b'FALSE', b'false']
 
 
 def _ensure_encoded(list lst):

pandas/core/arrays/categorical.py

@@ -510,6 +510,7 @@ def _from_inferred_categories(cls, inferred_categories, inferred_codes,
         Categorical
         """
         from pandas import Index, to_numeric, to_datetime, to_timedelta
+        from pandas._libs.parsers import _true_values
 
         cats = Index(inferred_categories)
 
@@ -525,10 +526,8 @@ def _from_inferred_categories(cls, inferred_categories, inferred_codes,
             elif is_timedelta64_dtype(dtype.categories):
                 cats = to_timedelta(inferred_categories, errors='coerce')
             elif dtype.categories.is_boolean():
-                # from _true_values in parsers.pyx
-                # TODO: share declaration with parsers.pyx
                 if true_values is None:
-                    true_values = [b'True', b'true', b'TRUE']
+                    true_values = _true_values
                 true_values = [x.decode() for x in true_values]
                 cats = cats.isin(true_values)
 

pandas/tests/io/parser/dtypes.py

@@ -236,7 +236,7 @@ def test_categoricaldtype_coerces_timedelta(self):
         'b\nTrue\nFalse\nNA\nFALSE',
     ])
     def test_categoricaldtype_coerces_boolen(self, data):
-        # 20498
+        # GH-20498
         dtype = {'b': CategoricalDtype([False, True])}
         expected = pd.DataFrame({"b": Categorical([True, False, None, False])})
         result = self.read_csv(StringIO(data), dtype=dtype)