Skip to content

Commit b708d92

Browse files
committed
change according to comments
1 parent e790a59 commit b708d92

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

doc/source/reference/indexing.rst

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,6 @@ Selecting
166166
Index.get_slice_bound
167167
Index.get_value
168168
Index.get_values
169-
Index.set_value
170169
Index.isin
171170
Index.slice_indexer
172171
Index.slice_locs

doc/source/whatsnew/v1.0.0.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,9 @@ Documentation Improvements
123123
Deprecations
124124
~~~~~~~~~~~~
125125

126-
- :meth:`Index.set_values` has been deprecated. For a given index ``idx``, array ``arr``,
126+
- `Index.set_value` has been deprecated. For a given index ``idx``, array ``arr``,
127127
value in ``idx`` of ``idx_val`` and a new value of ``val``, ``idx.set_value(arr, idx_val, val)``
128-
is equivalent to ``arr[idx.get_loc(idx_val) = val``, which should be used instead (:issue:`28621`).
128+
is equivalent to ``arr[idx.get_loc(idx_val)] = val``, which should be used instead (:issue:`28621`).
129129
-
130130

131131
.. _whatsnew_1000.prior_deprecations:

pandas/core/indexes/base.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,9 @@ class Index(IndexOpsMixin, PandasObject):
205205
"""
206206

207207
# tolist is not actually deprecated, just suppressed in the __dir__
208-
_deprecations = DirNamesMixin._deprecations | frozenset(["tolist", "dtype_str"])
208+
_deprecations = DirNamesMixin._deprecations | frozenset(
209+
["tolist", "dtype_str", "set_value"]
210+
)
209211

210212
# To hand over control to subclasses
211213
_join_precedence = 1

0 commit comments

Comments
 (0)