REF: Resampler subclasses remove unused arg, ensure parent is not None (#51163)

Author: jbrockmendel

pandas/core/resample.py

@@ -7,6 +7,7 @@
     Callable,
     Hashable,
     Literal,
+    cast,
     final,
     no_type_check,
 )
@@ -466,7 +467,7 @@ def _get_resampler_for_grouping(self, groupby, key=None):
         """
         Return the correct class for resampling with groupby.
         """
-        return self._resampler_for_grouping(self, groupby=groupby, key=key)
+        return self._resampler_for_grouping(groupby=groupby, key=key, parent=self)
 
     def _wrap_result(self, result):
         """
@@ -1142,11 +1143,11 @@ class _GroupByMixin(PandasObject):
     _attributes: list[str]  # in practice the same as Resampler._attributes
     _selection: IndexLabel | None = None
 
-    def __init__(self, obj, parent=None, groupby=None, key=None, **kwargs) -> None:
+    def __init__(self, *, parent: Resampler, groupby=None, key=None, **kwargs) -> None:
         # reached via ._gotitem and _get_resampler_for_grouping
 
-        if parent is None:
-            parent = obj
+        # parent is always a Resampler, sometimes a _GroupByMixin
+        assert isinstance(parent, Resampler), type(parent)
 
         # initialize our GroupByMixin object with
         # the resampler attributes
@@ -1219,7 +1220,10 @@ def _gotitem(self, key, ndim, subset=None):
             selection = key
 
         new_rs = type(self)(
-            subset, groupby=groupby, parent=self, selection=selection, **kwargs
+            groupby=groupby,
+            parent=cast(Resampler, self),
+            selection=selection,
+            **kwargs,
         )
         return new_rs