Remove some LSP sigs for _get_expected_exception

Test functions defined in `BaseArithmeticOpsTests` such as `test_arith_series_with_scalar` call `check_opname` which calls `_get_expected_exception`.  Because `TestArithmetic` in `test_numpy.py` overrides `_get_expected_exception` and needs to access the `request` parameter, we need a mechanism to pass `request` down and back up the type hiearchy, which we can do using LSP style parameters `*args` and `**kwargs`.

We could opt to do this consistently across all EA types, but since only `decimal/test_decimal.py` overrides, and because it doesn't actually use the `result` parameter, we instead simply omit `*args, **kwargs` when not needed.

Signed-off-by: Michael Tiemann <72577720+MichaelTiemannOSC@users.noreply.github.com>

Author: MichaelTiemannOSC

pandas/tests/extension/base/ops.py

@@ -19,7 +19,7 @@ class BaseOpsUtil:
     divmod_exc: type[Exception] | None = TypeError
 
     def _get_expected_exception(
-        self, op_name: str, obj, other, *args, **kwargs
+        self, op_name: str, obj, other
     ) -> type[Exception] | None:
         # Find the Exception, if any we expect to raise calling
         #  obj.__op_name__(other)

pandas/tests/extension/decimal/test_decimal.py

@@ -67,7 +67,7 @@ def data_for_grouping():
 
 class TestDecimalArray(base.ExtensionTests):
     def _get_expected_exception(
-        self, op_name: str, obj, other, *args, **kwargs
+        self, op_name: str, obj, other
     ) -> type[Exception] | None:
         return None
 
@@ -330,7 +330,7 @@ class TestArithmeticOps(base.BaseArithmeticOpsTests):
     series_array_exc = None
 
     def _get_expected_exception(
-        self, op_name: str, obj, other, *args, **kwargs
+        self, op_name: str, obj, other
     ) -> type[Exception] | None:
         return None
 

pandas/tests/extension/test_arrow.py

@@ -938,7 +938,7 @@ def _is_temporal_supported(self, opname, pa_dtype):
         )
 
     def _get_expected_exception(
-        self, op_name: str, obj, other, *args, **kwargs
+        self, op_name: str, obj, other
     ) -> type[Exception] | None:
         if op_name in ("__divmod__", "__rdivmod__"):
             return self.divmod_exc
@@ -1048,9 +1048,7 @@ def test_arith_series_with_scalar(self, data, all_arithmetic_operators, request)
         if mark is not None:
             request.node.add_marker(mark)
 
-        super().test_arith_series_with_scalar(
-            data, all_arithmetic_operators, request=request
-        )
+        super().test_arith_series_with_scalar(data, all_arithmetic_operators)
 
     def test_arith_frame_with_scalar(self, data, all_arithmetic_operators, request):
         pa_dtype = data.dtype.pyarrow_dtype
@@ -1064,9 +1062,7 @@ def test_arith_frame_with_scalar(self, data, all_arithmetic_operators, request):
         if mark is not None:
             request.node.add_marker(mark)
 
-            super().test_arith_frame_with_scalar(
-                data, all_arithmetic_operators, request=request
-            )
+            super().test_arith_frame_with_scalar(data, all_arithmetic_operators)
 
     def test_arith_series_with_array(self, data, all_arithmetic_operators, request):
         pa_dtype = data.dtype.pyarrow_dtype
@@ -1100,7 +1096,7 @@ def test_arith_series_with_array(self, data, all_arithmetic_operators, request):
         # since ser.iloc[0] is a python scalar
         other = pd.Series(pd.array([ser.iloc[0]] * len(ser), dtype=data.dtype))
 
-        self.check_opname(ser, op_name, other, request=request)
+        self.check_opname(ser, op_name, other)
 
     def test_add_series_with_extension_array(self, data, request):
         pa_dtype = data.dtype.pyarrow_dtype
@@ -1112,7 +1108,7 @@ def test_add_series_with_extension_array(self, data, request):
                     reason=f"raises on overflow for {pa_dtype}",
                 )
             )
-        super().test_add_series_with_extension_array(data, request=request)
+        super().test_add_series_with_extension_array(data)
 
     def test_invalid_other_comp(self, data, comparison_op):
         # GH 48833

pandas/tests/extension/test_datetime.py

@@ -83,10 +83,10 @@ def cmp(a, b):
 
 # ----------------------------------------------------------------------------
 class TestDatetimeArray(base.ExtensionTests):
-    def _get_expected_exception(self, op_name, obj, other, *args, **kwargs):
+    def _get_expected_exception(self, op_name, obj, other):
         if op_name in ["__sub__", "__rsub__"]:
             return None
-        return super()._get_expected_exception(op_name, obj, other, *args, **kwargs)
+        return super()._get_expected_exception(op_name, obj, other)
 
     def _supports_accumulation(self, ser, op_name: str) -> bool:
         return op_name in ["cummin", "cummax"]

pandas/tests/extension/test_masked.py

@@ -162,7 +162,7 @@ def data_for_grouping(dtype):
 
 
 class TestMaskedArrays(base.ExtensionTests):
-    def _get_expected_exception(self, op_name, obj, other, *args, **kwargs):
+    def _get_expected_exception(self, op_name, obj, other):
         try:
             dtype = tm.get_dtype(obj)
         except AttributeError:

pandas/tests/extension/test_period.py

@@ -72,10 +72,10 @@ def data_for_grouping(dtype):
 
 
 class TestPeriodArray(base.ExtensionTests):
-    def _get_expected_exception(self, op_name, obj, other, *args, **kwargs):
+    def _get_expected_exception(self, op_name, obj, other):
         if op_name in ("__sub__", "__rsub__"):
             return None
-        return super()._get_expected_exception(op_name, obj, other, *args, **kwargs)
+        return super()._get_expected_exception(op_name, obj, other)
 
     def _supports_accumulation(self, ser, op_name: str) -> bool:
         return op_name in ["cummin", "cummax"]

pandas/tests/extension/test_sparse.py

@@ -383,11 +383,11 @@ def _skip_if_different_combine(self, data):
 
     def test_arith_series_with_scalar(self, data, all_arithmetic_operators, request):
         self._skip_if_different_combine(data)
-        super().test_arith_series_with_scalar(data, all_arithmetic_operators, request)
+        super().test_arith_series_with_scalar(data, all_arithmetic_operators)
 
     def test_arith_series_with_array(self, data, all_arithmetic_operators, request):
         self._skip_if_different_combine(data)
-        super().test_arith_series_with_array(data, all_arithmetic_operators, request)
+        super().test_arith_series_with_array(data, all_arithmetic_operators)
 
     def test_arith_frame_with_scalar(self, data, all_arithmetic_operators, request):
         if data.dtype.fill_value != 0:
@@ -403,7 +403,7 @@ def test_arith_frame_with_scalar(self, data, all_arithmetic_operators, request):
         ]:
             mark = pytest.mark.xfail(reason="result dtype.fill_value mismatch")
             request.node.add_marker(mark)
-        super().test_arith_frame_with_scalar(data, all_arithmetic_operators, request)
+        super().test_arith_frame_with_scalar(data, all_arithmetic_operators)
 
 
 class TestComparisonOps(BaseSparseTests):