Skip to content

Commit 8b22858

Browse files
committed
add merge type validation on pandas.merge
1 parent aa134bb commit 8b22858

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

pandas/core/reshape/merge.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,10 @@ def merge(
350350
left_df = _validate_operand(left)
351351
left._check_copy_deprecation(copy)
352352
right_df = _validate_operand(right)
353-
if how == "cross":
353+
merge_type = ["left", "right", "inner", "outer", "cross"]
354+
if how not in merge_type:
355+
raise ValueError(f"'{how}' is not a valid Merge type ({merge_type})")
356+
elif how == "cross":
354357
return _cross_merge(
355358
left_df,
356359
right_df,

0 commit comments

Comments
 (0)