CLN: replace in bool block rather than special-casing in common

Author: cpcloud

pandas/core/common.py

@@ -347,13 +347,7 @@ def mask_missing(arr, values_to_mask):
         values_to_mask = [values_to_mask]
 
     try:
-        values = np.array(values_to_mask)
-        cant_cast = not np.can_cast(values.dtype, arr.dtype, casting='safe')
-
-        if cant_cast and arr.dtype == np.bool_:
-            values_to_mask = values
-        else:
-            values_to_mask = np.array(values_to_mask, dtype=arr.dtype)
+        values_to_mask = np.array(values_to_mask, dtype=arr.dtype)
     except Exception:
         values_to_mask = np.array(values_to_mask, dtype=object)
 

pandas/core/internals.py

@@ -1216,6 +1216,7 @@ def should_store(self, value):
         return (issubclass(value.dtype.type, np.floating) and
                 value.dtype == self.dtype)
 
+
 class ComplexBlock(FloatOrComplexBlock):
     is_complex = True
 
@@ -1355,6 +1356,14 @@ def _try_cast(self, element):
     def should_store(self, value):
         return issubclass(value.dtype.type, np.bool_)
 
+    def replace(self, to_replace, value, inplace=False, filter=None,
+                regex=False):
+        to_replace_values = np.atleast_1d(to_replace)
+        if not np.can_cast(to_replace_values, bool):
+            to_replace = to_replace_values
+        return super(BoolBlock, self).replace(to_replace, value,
+                                              inplace=inplace, filter=filter,
+                                              regex=regex)
 
 class ObjectBlock(Block):
     is_object = True