Skip to content

Commit 7cfc2e2

Browse files
committed
Fix tests
1 parent eae6ffc commit 7cfc2e2

File tree

4 files changed

+20
-2
lines changed

4 files changed

+20
-2
lines changed

pandas/tests/extension/base/methods.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -249,14 +249,17 @@ def test_fillna_copy_frame(self, data_missing):
249249

250250
assert df.A.values is not result.A.values
251251

252-
def test_fillna_copy_series(self, data_missing):
252+
def test_fillna_copy_series(self, data_missing, no_op_with_cow: bool = False):
253253
arr = data_missing.take([1, 1])
254254
ser = pd.Series(arr)
255255

256256
filled_val = ser[0]
257257
result = ser.fillna(filled_val)
258258

259-
assert ser._values is not result._values
259+
if no_op_with_cow:
260+
assert ser._values is result._values
261+
else:
262+
assert ser._values is not result._values
260263
assert ser._values is arr
261264

262265
def test_fillna_length_mismatch(self, data_missing):

pandas/tests/extension/test_datetime.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,11 @@ def test_combine_add(self, data_repeated):
116116
# Timestamp.__add__(Timestamp) not defined
117117
pass
118118

119+
def test_fillna_copy_series(self, data_missing, using_copy_on_write):
120+
super().test_fillna_copy_series(
121+
data_missing, no_op_with_cow=using_copy_on_write
122+
)
123+
119124

120125
class TestInterface(BaseDatetimeTests, base.BaseInterfaceTests):
121126
pass

pandas/tests/extension/test_interval.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,11 @@ def test_combine_add(self, data_repeated):
132132
def test_fillna_length_mismatch(self, data_missing):
133133
super().test_fillna_length_mismatch(data_missing)
134134

135+
def test_fillna_copy_series(self, data_missing, using_copy_on_write):
136+
super().test_fillna_copy_series(
137+
data_missing, no_op_with_cow=using_copy_on_write
138+
)
139+
135140

136141
class TestMissing(BaseInterval, base.BaseMissingTests):
137142
# Index.fillna only accepts scalar `value`, so we have to xfail all

pandas/tests/extension/test_period.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,11 @@ def test_diff(self, data, periods):
105105
else:
106106
super().test_diff(data, periods)
107107

108+
def test_fillna_copy_series(self, data_missing, using_copy_on_write):
109+
super().test_fillna_copy_series(
110+
data_missing, no_op_with_cow=using_copy_on_write
111+
)
112+
108113

109114
class TestInterface(BasePeriodTests, base.BaseInterfaceTests):
110115

0 commit comments

Comments
 (0)