CLN: Use new-style classes instead of old-style classes

Author: jschendel

ci/lint.sh

@@ -165,6 +165,14 @@ if [ "$LINT" ]; then
         RET=1
     fi
     echo "Check for deprecated messages without sphinx directive DONE"
+
+    echo "Check for old-style classes"
+    grep -R --include="*.py" -E "class\s\S*[^)]:" pandas scripts
+
+    if [ $? = "0" ]; then
+        RET=1
+    fi
+    echo "Check for old-style classes DONE"
 
 else
     echo "NOT Linting"

pandas/_version.py

@@ -25,7 +25,7 @@ def get_keywords():
     return keywords
 
 
-class VersioneerConfig:
+class VersioneerConfig(object):
     pass
 
 

pandas/io/common.py

@@ -534,7 +534,7 @@ def __next__(self):
             row = next(self.reader)
             return [compat.text_type(s, "utf-8") for s in row]
 
-    class UnicodeWriter:
+    class UnicodeWriter(object):
 
         """
         A CSV writer which will write rows to CSV file "f",

pandas/io/sas/sas_constants.py

@@ -102,7 +102,7 @@
                   61: "wcyrillic", 62: "wlatin1", 90: "ebcdic870"}
 
 
-class index:
+class index(object):
     rowSizeIndex = 0
     columnSizeIndex = 1
     subheaderCountsIndex = 2

pandas/tests/frame/test_analytics.py

@@ -1215,7 +1215,7 @@ def wrapper(x):
         getattr(mixed, name)(axis=0)
         getattr(mixed, name)(axis=1)
 
-        class NonzeroFail:
+        class NonzeroFail(object):
 
             def __nonzero__(self):
                 raise ValueError

pandas/tests/indexing/test_panel.py

@@ -149,7 +149,7 @@ def test_panel_getitem(self):
 
             # with an object-like
             # GH 9140
-            class TestObject:
+            class TestObject(object):
 
                 def __str__(self):
                     return "TestObject"

pandas/tests/io/formats/test_format.py

@@ -1621,7 +1621,7 @@ def test_pprint_pathological_object(self):
         If the test fails, it at least won't hang.
         """
 
-        class A:
+        class A(object):
             def __getitem__(self, key):
                 return 3  # obviously simplified
 

pandas/tests/io/json/test_ujson.py

@@ -460,11 +460,11 @@ def test_decodeFromUnicode(self):
     def test_encodeRecursionMax(self):
         # 8 is the max recursion depth
 
-        class O2:
+        class O2(object):
             member = 0
             pass
 
-        class O1:
+        class O1(object):
             member = 0
             pass
 
@@ -772,7 +772,7 @@ def test_dumpToFile(self):
         assert "[1,2,3]" == f.getvalue()
 
     def test_dumpToFileLikeObject(self):
-        class filelike:
+        class filelike(object):
 
             def __init__(self):
                 self.bytes = ''
@@ -800,7 +800,7 @@ def test_loadFile(self):
             np.array([1, 2, 3, 4]), ujson.load(f, numpy=True))
 
     def test_loadFileLikeObject(self):
-        class filelike:
+        class filelike(object):
 
             def read(self):
                 try:
@@ -837,7 +837,7 @@ def test_encodeNumericOverflow(self):
 
     def test_encodeNumericOverflowNested(self):
         for n in range(0, 100):
-            class Nested:
+            class Nested(object):
                 x = 12839128391289382193812939
 
             nested = Nested()
@@ -886,7 +886,7 @@ def test_decodeBigEscape(self):
     def test_toDict(self):
         d = {u("key"): 31337}
 
-        class DictTest:
+        class DictTest(object):
 
             def toDict(self):
                 return d

pandas/tests/scalar/timedelta/test_timedelta.py

@@ -37,7 +37,7 @@ def test_ops_error_str(self):
             assert left != right
 
     def test_ops_notimplemented(self):
-        class Other:
+        class Other(object):
             pass
 
         other = Other()

pandas/tests/sparse/frame/test_frame.py

@@ -227,7 +227,7 @@ def test_constructor_from_dense_series(self):
 
     def test_constructor_from_unknown_type(self):
         # GH 19393
-        class Unknown:
+        class Unknown(object):
             pass
         with pytest.raises(TypeError,
                            message='SparseDataFrame called with unknown type '

pandas/tests/test_errors.py

@@ -54,7 +54,7 @@ def test_error_rename():
             pass
 
 
-class Foo:
+class Foo(object):
     @classmethod
     def classmethod(cls):
         raise AbstractMethodError(cls, methodtype='classmethod')

pandas/tests/test_resample.py

@@ -1082,7 +1082,7 @@ def test_resample_how_callables(self):
         def fn(x, a=1):
             return str(type(x))
 
-        class fn_class:
+        class fn_class(object):
 
             def __call__(self, x):
                 return str(type(x))

scripts/validate_docstrings.py

@@ -94,7 +94,7 @@ def _output_header(title, width=80, char='#'):
         full_line=full_line, title_line=title_line)
 
 
-class Docstring:
+class Docstring(object):
     def __init__(self, method_name, method_obj):
         self.method_name = method_name
         self.method_obj = method_obj

versioneer.py

@@ -352,7 +352,7 @@
 import sys
 
 
-class VersioneerConfig:
+class VersioneerConfig(object):
     pass