Skip to content

Commit 6cadc23

Browse files
committed
CLN: simplify MultiIndex._shallow_copy
1 parent c407b73 commit 6cadc23

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

pandas/core/indexes/multi.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -924,12 +924,12 @@ def __contains__(self, key):
924924

925925
@Appender(_index_shared_docs['_shallow_copy'])
926926
def _shallow_copy(self, values=None, **kwargs):
927+
names = kwargs.pop('names', kwargs.pop('name', self.names))
927928
if values is not None:
928-
names = kwargs.pop('names', kwargs.pop('name', self.names))
929929
# discards freq
930930
kwargs.pop('freq', None)
931931
return MultiIndex.from_tuples(values, names=names, **kwargs)
932-
return self.view()
932+
return self.copy(names=names, **kwargs)
933933

934934
@cache_readonly
935935
def dtype(self):
@@ -1810,7 +1810,7 @@ def remove_unused_levels(self):
18101810
new_levels.append(lev)
18111811
new_codes.append(level_codes)
18121812

1813-
result = self._shallow_copy()
1813+
result = self.view()
18141814

18151815
if changed:
18161816
result._reset_identity()

pandas/tests/indexes/multi/test_equivalence.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ def test_is_():
175175
assert mi2.is_(mi)
176176
assert mi.is_(mi2)
177177

178-
assert mi.is_(mi.set_names(["C", "D"]))
178+
assert not mi.is_(mi.set_names(["C", "D"]))
179179
mi2 = mi.view()
180180
mi2.set_names(["E", "F"], inplace=True)
181181
assert mi.is_(mi2)

0 commit comments

Comments
 (0)