Adjust for editable support in meson-python

Author: lithomas1

.github/workflows/32-bit-linux.yml

@@ -43,9 +43,9 @@ jobs:
           pip install "git+https://github.com/mesonbuild/meson-python.git@main" && \
           python -m pip install versioneer[toml] && \
           export PANDAS_CI=1 && \
-          python -m pip install --no-build-isolation -v . && \
+          python -m pip install --no-build-isolation -ev . && \
           python -m pip list && \
-          pytest -m 'not slow and not network and not clipboard and not single_cpu' pandas --junitxml=test-data.xml --import-mode=importlib"
+          pytest -m 'not slow and not network and not clipboard and not single_cpu' pandas --junitxml=test-data.xml
 
       - name: Publish test results for Python 3.8-32 bit full Linux
         uses: actions/upload-artifact@v3

.github/workflows/code-checks.yml

@@ -70,7 +70,7 @@ jobs:
       if: ${{ steps.build.outcome == 'success' && always() }}
 
     - name: Run checks on imported code
-      run: cd ci && ./code_checks.sh code
+      run: ci/code_checks.sh code
       if: ${{ steps.build.outcome == 'success' && always() }}
 
     - name: Run doctests
@@ -99,7 +99,7 @@ jobs:
       if: ${{ steps.build.outcome == 'success' && always() }}
 
     - name: Run docstring validation script tests
-      run: pytest scripts --import-mode=append
+      run: pytest scripts
       if: ${{ steps.build.outcome == 'success' && always() }}
 
   asv-benchmarks:

.github/workflows/docbuild-and-upload.yml

@@ -49,10 +49,10 @@ jobs:
       run: python web/pandas_web.py web/pandas --target-path=web/build
 
     - name: Build documentation
-      run: python doc/make.py --warnings-are-errors
+      run: doc/make.py --warnings-are-errors
 
     - name: Build documentation zip
-      run: python doc/make.py zip_html
+      run: doc/make.py zip_html
 
     - name: Install ssh key
       run: |

.github/workflows/package-checks.yml

@@ -52,5 +52,5 @@ jobs:
 
       - name: Pip install with extra
         run: |
-          python -m pip install .[${{ matrix.extra }}] -v
+          python -m pip install .[${{ matrix.extra }}] -v --no-build-isolation
         shell: bash -el {0}

.github/workflows/python-dev.yml

@@ -85,11 +85,11 @@ jobs:
 
       # Sigh, someone (numpy?) is depending on mingw, which pandas doesn't compile with.
       # Also, meson doesn't detect visual c++ unless cl.exe is in path.
-      # TODO: File a bug with meson about this.
+      # TODO: File a bug with meson-python about this.
     - name: Build Pandas
       if : ${{ runner.os != 'Windows' }}
       run: |
-        python3 -m pip install . --no-build-isolation -v
+        python3 -m pip install -ve . --no-build-isolation
       shell: bash -el {0}
 
     - name: Build Pandas (Windows)
@@ -102,8 +102,7 @@ jobs:
 
     - name: Build Version
       run: |
-        # Can't import pandas from the source directory
-        cd .. && python -c "import pandas; pandas.show_versions();"
+        python -c "import pandas; pandas.show_versions();"
 
     - name: Test
       uses: ./.github/actions/run-tests

.github/workflows/sdist.yml

@@ -46,12 +46,9 @@ jobs:
 
     - name: Install dependencies
       run: |
-        python -m pip install --upgrade pip setuptools wheel build Cython oldest-supported-numpy
+        python -m pip install --upgrade pip setuptools wheel build
         python -m pip install versioneer[toml]
 
-        # GH 39416
-        pip install numpy
-
     - name: Build pandas sdist
       run: |
         pip list

Dockerfile

@@ -7,7 +7,6 @@ RUN apt-get install -y build-essential
 # hdf5 needed for pytables installation
 RUN apt-get install -y libhdf5-dev
 
-
 RUN python -m pip install --upgrade pip
 RUN python -m pip install \
     -r https://raw.githubusercontent.com/pandas-dev/pandas/main/requirements-dev.txt

ci/code_checks.sh

@@ -67,14 +67,11 @@ if [[ -z "$CHECK" || "$CHECK" == "doctests" ]]; then
 
     MSG='Doctests' ; echo $MSG
     # Ignore test_*.py files or else the unit tests will run
-    # cd out of pandas directory, otherwise regular unit tests will also be collected
-    # TODO: fix?
-    cd ~
-    python -c 'import pandas as pd; pd.test(extra_args=["--doctest-modules", "--ignore-glob=**/test_*.py", "-v"])'
+    python -m pytest --doctest-modules --ignore-glob="**/test_*.py" pandas
     RET=$(($RET + $?)) ; echo $MSG "DONE"
 
     MSG='Cython Doctests' ; echo $MSG
-    python -c 'import pandas as pd; pd.test(extra_args=["--doctest-cython", "--ignore-glob=**/test_*.py", "-v"])'
+    python -m pytest --doctest-cython pandas/_libs
     RET=$(($RET + $?)) ; echo $MSG "DONE"
 
 fi

ci/run_tests.sh

@@ -1,6 +1,5 @@
 #!/bin/bash -e
 
-
 # Workaround for pytest-xdist (it collects different tests in the workers if PYTHONHASHSEED is not set)
 # https://github.com/pytest-dev/pytest/issues/920
 # https://github.com/pytest-dev/pytest/issues/1075
@@ -14,7 +13,7 @@ if [[ "not network" == *"$PATTERN"* ]]; then
 fi
 
 if [[ "$COVERAGE" == "true" ]]; then
-    COVERAGE="-s --cov=pandas --cov-report=xml --cov-append --cov-config=setup.cfg"
+    COVERAGE="-s --cov=pandas --cov-report=xml --cov-append"
 else
     COVERAGE="" # We need to reset this for COVERAGE="false" case
 fi
@@ -25,7 +24,7 @@ if [[ $(uname) == "Linux" && -z $DISPLAY ]]; then
     XVFB="xvfb-run "
 fi
 
-PYTEST_CMD="${XVFB}pytest -r fEs -n $PYTEST_WORKERS --dist=loadfile --import-mode=importlib $TEST_ARGS $COVERAGE $PYTEST_TARGET"
+PYTEST_CMD="${XVFB}pytest -r fEs -n $PYTEST_WORKERS --dist=loadfile $TEST_ARGS $COVERAGE $PYTEST_TARGET"
 
 if [[ "$PATTERN" ]]; then
   PYTEST_CMD="$PYTEST_CMD -m \"$PATTERN\""
@@ -34,7 +33,7 @@ fi
 echo $PYTEST_CMD
 sh -c "$PYTEST_CMD"
 
-if [[ "$PANDAS_DATA_MANAGER" != "array" && "$PYTEST_TARGET" == "pandas/pandas" ]]; then
+if [[ "$PANDAS_DATA_MANAGER" != "array" && "$PYTEST_TARGET" == "pandas" ]]; then
     # The ArrayManager tests should have already been run by PYTEST_CMD if PANDAS_DATA_MANAGER was already set to array
     # If we're targeting specific files, e.g. test_downstream.py, don't run.
     PYTEST_AM_CMD="PANDAS_DATA_MANAGER=array pytest -n $PYTEST_WORKERS --dist=loadfile $TEST_ARGS $COVERAGE pandas"

doc/make.py

@@ -324,6 +324,9 @@ def main():
             "'ecosystem.rst', 'pandas.DataFrame.join'"
         ),
     )
+    argparser.add_argument(
+        "--python-path", type=str, default=os.path.dirname(DOC_PATH), help="path"
+    )
     argparser.add_argument(
         "-v",
         action="count",
@@ -350,6 +353,8 @@ def main():
     # external libraries (namely Sphinx) to compile this module and resolve
     # the import of `python_path` correctly. The latter is used to resolve
     # the import within the module, injecting it into the global namespace
+    os.environ["PYTHONPATH"] = args.python_path
+    sys.path.insert(0, args.python_path)
     globals()["pandas"] = importlib.import_module("pandas")
 
     # Set the matplotlib backend to the non-interactive Agg backend for all

doc/source/development/contributing_codebase.rst

@@ -787,11 +787,6 @@ options or subtle interactions to test (or think of!) all of them.
 Running the test suite
 ----------------------
 
-.. note::
-   If you have built pandas with meson, you'll need to add the
-   ``--import-mode=importlib`` flag to each pytest invocation, or pandas
-   will fail to import in the tests.
-
 The tests can then be run directly inside your Git clone (without having to
 install pandas) by typing::