Skip to content

Commit 5c3fdc3

Browse files
cpcloudjreback
authored andcommitted
CLN: pandas stata reader should clean up after itself
CLN: ensure_clean in stata temp data files, thanks @cpcloud
1 parent 9209345 commit 5c3fdc3

File tree

1 file changed

+11
-14
lines changed

1 file changed

+11
-14
lines changed

pandas/io/tests/test_stata.py

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,7 @@
1313
from pandas.io.parsers import read_csv
1414
from pandas.io.stata import read_stata, StataReader, StataWriter
1515
import pandas.util.testing as tm
16-
17-
18-
def curpath():
19-
pth, _ = os.path.split(os.path.abspath(__file__))
20-
return pth
21-
16+
from pandas.util.testing import ensure_clean
2217

2318
class StataTests(unittest.TestCase):
2419

@@ -136,20 +131,22 @@ def test_write_dta5(self):
136131
original = DataFrame([(np.nan, np.nan, np.nan, np.nan, np.nan)],
137132
columns=['float_miss', 'double_miss', 'byte_miss', 'int_miss', 'long_miss'])
138133

139-
writer = StataWriter(self.dta5, original, None, False)
140-
writer.write_file()
134+
with ensure_clean(self.dta5) as path:
135+
writer = StataWriter(path, original, None, False)
136+
writer.write_file()
141137

142-
written_and_read_again = self.read_dta(self.dta5)
143-
tm.assert_frame_equal(written_and_read_again, original)
138+
written_and_read_again = self.read_dta(path)
139+
tm.assert_frame_equal(written_and_read_again, original)
144140

145141
def test_write_dta6(self):
146142
original = self.read_csv(self.csv3)
147143

148-
writer = StataWriter(self.dta6, original, None, False)
149-
writer.write_file()
144+
with ensure_clean(self.dta6) as path:
145+
writer = StataWriter(path, original, None, False)
146+
writer.write_file()
150147

151-
written_and_read_again = self.read_dta(self.dta6)
152-
tm.assert_frame_equal(written_and_read_again, original)
148+
written_and_read_again = self.read_dta(path)
149+
tm.assert_frame_equal(written_and_read_again, original)
153150

154151
@nose.tools.nottest
155152
def test_read_dta7(self):

0 commit comments

Comments
 (0)