DOC: moves examples from whatsnew to indexing

Author: deniederhut

doc/source/indexing.rst

@@ -227,10 +227,6 @@ as an attribute:
    dfa.A
    panel.one
 
-You can use attribute access to modify an existing element of a Series or column of a DataFrame, but be careful;
-if you try to use attribute access to create a new column, it creates a new attribute rather than a
-new column. This behavior will incur a ``UserWarning`` in 0.21.0 and later.
-
 .. ipython:: python
 
    sa.a = 5
@@ -267,6 +263,37 @@ You can also assign a ``dict`` to a row of a ``DataFrame``:
    x.iloc[1] = dict(x=9, y=99)
    x
 
+You can use attribute access to modify an existing element of a Series or column of a DataFrame, but be careful;
+if you try to use attribute access to create a new column, it creates a new attribute rather than a
+new column. In 0.21.0 and later, this will raise a ``UserWarning``:
+
+.. code-block:: ipython
+
+    In[1]: df = pd.DataFrame({'one': [1., 2., 3.]})
+    In[2]: df.two = [4, 5, 6]
+    UserWarning: Pandas doesn't allow Series to be assigned into nonexistent columns - see https://pandas.pydata.org/pandas-docs/stable/indexing.html#attribute-access
+    In[3]: df
+    Out[3]:
+       one
+    0  1.0
+    1  2.0
+    2  3.0
+
+Similarly, it is possible to create a column with a name which collides with one of Pandas's
+built-in methods or attributes, which can cause confusion later when attempting to access
+that column as an attribute. This behavior now warns:
+
+.. code-block:: ipython
+
+    In[4]: df['sum'] = [5., 7., 9.]
+    UserWarning: Column name 'sum' collides with a built-in method, which will cause unexpected attribute behavior
+    In[5]: df.sum
+    Out[5]:
+    <bound method DataFrame.sum of    one  sum
+    0  1.0  5.0
+    1  2.0  7.0
+    2  3.0  9.0>
+
 Slicing ranges
 --------------
 

doc/source/whatsnew/v0.21.0.txt

@@ -59,7 +59,7 @@ using the :func:`to_numeric` function (or :func:`to_datetime`, :func:`to_timedel
    df['C'] = pd.to_numeric(df['C'], errors='coerce')
    df.dtypes
 
-.. _whatsnew_0210.enhancements.column_creation:
+.. _whatsnew_0210.enhancements.column-creation:
 
 Improved warnings when attempting to create columns
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -73,7 +73,7 @@ of this confusion include attempting to create a new column by setting into an a
   In[1]: df = pd.DataFrame({'one': [1., 2., 3.]})
   In[2]: df.two = [4, 5, 6]
 
-which does not raise any obvious exceptions, but also does not create a new column:
+This does not raise any obvious exceptions, but also does not create a new column:
 
 .. code-block:: ipython
 
@@ -84,14 +84,14 @@ which does not raise any obvious exceptions, but also does not create a new colu
   1  2.0
   2  3.0
 
-and creating a column whose name collides with a method or attribute already in the instance
-namespace:
+The second source of confusion is creating a column whose name collides with a method or
+attribute already in the instance namespace:
 
 .. code-block:: ipython
 
   In[4]: df['sum'] = [5., 7., 9.]
 
-which does not permit that column to be accessed as an attribute:
+This does not permit that column to be accessed as an attribute:
 
 .. code-block:: ipython
 
@@ -102,19 +102,7 @@ which does not permit that column to be accessed as an attribute:
   1  2.0  7.0
   2  3.0  9.0>
 
-Both of these now raise a ``UserWarning`` about the potential for unexpected behavior. Upon executing input 2, you can now expect to see:
-
-.. code-block:: ipython
-
-  In[2]: df.two = [4, 5, 6]
-  UserWarning: Pandas doesn't allow Series to be assigned into nonexistent columns - see https://pandas.pydata.org/pandas-docs/stable/indexing.html#attribute-access
-
-and the example in input 4 will now produce:
-
-.. code-block:: ipython
-
-  In[4]: df['sum'] = [5., 7., 9.]
-  UserWarning: Column name 'sum' collides with a built-in method, which will cause unexpected attribute behavior
+Both of these now raise a ``UserWarning`` about the potential for unexpected behavior. See `Attribute Access <https://pandas.pydata.org/pandas-docs/stable/indexing.html#attribute-access>`__.
 
 .. _whatsnew_0210.enhancements.other: