Skip to content

Commit 4d4baa2

Browse files
committed
center is not implemented for offset based windows
1 parent 4968d65 commit 4d4baa2

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

pandas/core/window.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1028,6 +1028,12 @@ def validate(self):
10281028
"compat with a datetimelike "
10291029
"index".format(self.window))
10301030

1031+
# we don't allow center
1032+
if self.center:
1033+
raise NotImplementedError("center is not implemented "
1034+
"for datetimelike and offset "
1035+
"based windows")
1036+
10311037
# this will raise ValueError on non-fixed freqs
10321038
self.window = freq.nanos
10331039
self.win_type = 'freq'

pandas/tests/test_window.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3129,6 +3129,10 @@ def test_valid(self):
31293129
with self.assertRaises(ValueError):
31303130
df.rolling(window='1D', min_periods=minp)
31313131

3132+
# center is not implemented
3133+
with self.assertRaises(NotImplementedError):
3134+
df.rolling(window='1D', center=True)
3135+
31323136
def test_on(self):
31333137

31343138
df = self.regular

0 commit comments

Comments
 (0)