Amend after 1st review

Author: makbigc

doc/source/whatsnew/v0.25.1.rst

@@ -16,11 +16,6 @@ For example, on MacOS installing Python with `pyenv` may lead to an incomplete P
 
 .. _whatsnew_0251.bug_fixes:
 
-Other deprecations
-^^^^^^^^^^^^^^^^^^
-
-- The parameter ``numeric_only`` of :meth:`Categorical.min` and :meth:`Categorical.max` is deprecated and replaced with ``skipna`` (:issue:`25303`)
-
 Bug fixes
 ~~~~~~~~~
 

doc/source/whatsnew/v1.0.0.rst

@@ -169,6 +169,7 @@ Deprecations
 - ``Index.set_value`` has been deprecated. For a given index ``idx``, array ``arr``,
   value in ``idx`` of ``idx_val`` and a new value of ``val``, ``idx.set_value(arr, idx_val, val)``
   is equivalent to ``arr[idx.get_loc(idx_val)] = val``, which should be used instead (:issue:`28621`).
+- The parameter ``numeric_only`` of :meth:`Categorical.min` and :meth:`Categorical.max` is deprecated and replaced with ``skipna`` (:issue:`25303`)
 -
 
 .. _whatsnew_1000.prior_deprecations:

pandas/tests/arrays/categorical/test_analytics.py

@@ -35,31 +35,34 @@ def test_min_max(self):
         assert _min == "d"
         assert _max == "a"
 
+    @pytest.mark.parametrize("skipna", [True, False])
+    def test_min_max_with_nan(self, skipna):
+        # GH 25303
         cat = Categorical(
             [np.nan, "b", "c", np.nan], categories=["d", "c", "b", "a"], ordered=True
         )
-        _min = cat.min(skipna=False)
-        _max = cat.max(skipna=False)
-        assert np.isnan(_min)
-        assert np.isnan(_max)
+        _min = cat.min(skipna=skipna)
+        _max = cat.max(skipna=skipna)
 
-        _min = cat.min()
-        assert _min == "c"
-        _max = cat.max()
-        assert _max == "b"
+        if skipna is False:
+            assert np.isnan(_min)
+            assert np.isnan(_max)
+        else:
+            assert _min == "c"
+            assert _max == "b"
 
         cat = Categorical(
             [np.nan, 1, 2, np.nan], categories=[5, 4, 3, 2, 1], ordered=True
         )
-        _min = cat.min(skipna=False)
-        _max = cat.max(skipna=False)
-        assert np.isnan(_min)
-        assert np.isnan(_max)
-
-        _min = cat.min()
-        assert _min == 2
-        _max = cat.max()
-        assert _max == 1
+        _min = cat.min(skipna=skipna)
+        _max = cat.max(skipna=skipna)
+
+        if skipna is False:
+            assert np.isnan(_min)
+            assert np.isnan(_max)
+        else:
+            assert _min == 2
+            assert _max == 1
 
     @pytest.mark.parametrize("method", ["min", "max"])
     def test_deprecate_numeric_only_min_max(self, method):