Skip to content

Commit 3f5cb0e

Browse files
committed
Use default true. Be silent if unsupported pytables
1 parent 37ad0c9 commit 3f5cb0e

File tree

2 files changed

+4
-14
lines changed

2 files changed

+4
-14
lines changed

pandas/io/pytables.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -981,7 +981,7 @@ def put(
981981
data_columns: Optional[List[str]] = None,
982982
encoding=None,
983983
errors: str = "strict",
984-
track_times: Optional[bool] = None,
984+
track_times: bool = True,
985985
):
986986
"""
987987
Store object in HDFStore.
@@ -1625,7 +1625,7 @@ def _write_to_group(
16251625
data_columns=None,
16261626
encoding=None,
16271627
errors: str = "strict",
1628-
track_times: Optional[bool] = None,
1628+
track_times: bool = True,
16291629
):
16301630
group = self.get_node(key)
16311631

@@ -4106,7 +4106,7 @@ def write(
41064106
dropna=False,
41074107
nan_rep=None,
41084108
data_columns=None,
4109-
track_times=None,
4109+
track_times=True,
41104110
):
41114111

41124112
if not append and self.is_exists:
@@ -4144,10 +4144,6 @@ def write(
41444144

41454145
if LooseVersion(tables_version) >= LooseVersion("3.4.3"):
41464146
options["track_times"] = track_times
4147-
else:
4148-
raise ValueError(
4149-
"You cannot set track_times with table version < 3.4.3"
4150-
)
41514147

41524148
# create the table
41534149
table._handle.create_table(table.group, **options)

pandas/tests/io/pytables/test_store.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -328,13 +328,7 @@ def create_h5_and_return_checksum(track_times):
328328

329329
return checksum(path)
330330

331-
if LooseVersion(tables.__version__) < LooseVersion("3.4.3"):
332-
with pytest.raises(
333-
ValueError,
334-
match="You cannot set track_times with table version < 3.4.3",
335-
):
336-
create_h5_and_return_checksum(track_times=False)
337-
else:
331+
if LooseVersion(tables.__version__) >= LooseVersion("3.4.3"):
338332
checksum_0_tt_false = create_h5_and_return_checksum(track_times=False)
339333
checksum_0_tt_true = create_h5_and_return_checksum(track_times=True)
340334

0 commit comments

Comments
 (0)