BUG: Fix broken tests. (39701)

Author: alexprincel

pandas/tests/util/test_show_versions.py

@@ -1,6 +1,7 @@
 import json
 import os
 import re
+from itertools import chain
 
 import pytest
 
@@ -39,14 +40,9 @@ def test_show_versions(capsys, as_json, tmpdir):
     pd.show_versions(as_json=as_json)
     captured = capsys.readouterr()
     result = captured.out
-    string_check = result
-
-    # check valid json is printed to the console if as_json is True
-    if as_json is True:
-        json.loads(result)
 
     # check header for non-JSON console output
-    elif as_json is False:
+    if as_json is False:
         assert "INSTALLED VERSIONS" in result
 
         # check full commit hash
@@ -59,26 +55,29 @@ def test_show_versions(capsys, as_json, tmpdir):
         # check optional dependency
         assert re.search(r"pyarrow\s*:\s([0-9\.]+|None)\n", result)
 
-    elif isinstance(as_json, str):
-        # make sure that the file was created
-        assert os.path.exists(as_json)
+    # Dictionary-based asserts
+    else:
+        # check valid json is printed to the console if as_json is True
+        if as_json is True:
+            dict_check = json.loads(result)
+        elif isinstance(as_json, str):
+            # make sure that the file was created
+            assert os.path.exists(as_json)
 
-        with open(as_json) as fd:
-            contents = fd.readlines()
-            str_contents = "".join(contents)
+            with open(as_json) as fd:
+                contents = fd.readlines()
+                str_contents = "".join(contents)
 
-            # make sure that there was output to the file
-            assert str_contents
+                # make sure that there was output to the file
+                assert str_contents
 
-            # check if file output is valid JSON
-            json.loads(str_contents)
+                # check if file output is valid JSON
+                dict_check = json.loads(str_contents)
 
-            # prepare string for checking for specific keys
-            string_check = str_contents
+        # Basic check that each version element is found in output
+        version_elements = dict(system = _get_sys_info(), dependencies = _get_dependency_info())
 
-    # Basic check that each version element is found in output
-    version_elements = {**_get_sys_info, **_get_dependency_info}
-    assert all(v in string_check and k in string_check for k, v in version_elements)
+        assert version_elements == dict_check 
 
 
 def test_json_output_match(capsys, tmpdir):