cleanups, fix bad filter

Author: TomAugspurger

pandas/tests/indexes/datetimes/test_construction.py

@@ -592,8 +592,9 @@ def test_constructor_with_int_tz(self, klass, box, tz, dtype):
         expected = klass([ts])
         assert result == expected
 
-    @pytest.mark.xfail(reason="TBD", strict=False)  # non-strict for tz-naive
-    @pytest.mark.filterwarnings("ignore:Passing integer:FutureWarning")
+    # This is the desired future behavior
+    @pytest.mark.xfail(reason="TBD", strict=False)
+    @pytest.mark.filterwarnings("ignore:\\n    Passing:FutureWarning")
     def test_construction_int_rountrip(self, tz_naive_fixture):
         # GH 12619
         tz = tz_naive_fixture

pandas/tests/indexes/test_base.py

@@ -398,10 +398,11 @@ def test_constructor_dtypes_to_timedelta(self, cast_index, vals):
     @pytest.mark.parametrize("klass", [pd.Index, pd.DatetimeIndex])
     def test_constructor_dtypes_datetime(self, tz_naive_fixture, attr, utc,
                                          klass):
-        # TODO: update comment
         # Test constructing with a datetimetz dtype
         # .values produces numpy datetimes, so these are considered naive
         # .asi8 produces integers, so these are considered epoch timestamps
+        # ^the above will be true in a later version. Right now we `.view`
+        # the i8 values as NS_DTYPE, effectively treating them as wall times.
         index = pd.date_range('2011-01-01', periods=5)
         arg = getattr(index, attr)
         index = index.tz_localize(tz_naive_fixture)
@@ -413,6 +414,8 @@ def test_constructor_dtypes_datetime(self, tz_naive_fixture, attr, utc,
         else:
             ex_warn = None
 
+        # stacklevel is checked elsewhere. We don't do it here since
+        # Index will have an frame, throwing off the expected.
         with tm.assert_produces_warning(ex_warn, check_stacklevel=False):
             result = klass(arg, tz=tz_naive_fixture)
         tm.assert_index_equal(result, index)

pandas/tests/test_base.py

@@ -1037,7 +1037,7 @@ class TestToIterable(object):
             lambda x: list(x.__iter__()),
         ], ids=['tolist', 'to_list', 'list', 'iter'])
     @pytest.mark.parametrize('typ', [Series, Index])
-    @pytest.mark.filterwarnings("ignore::FutureWarning")
+    @pytest.mark.filterwarnings("ignore:\\n    Passing:FutureWarning")
     def test_iterable(self, typ, method, dtype, rdtype):
         # gh-10904
         # gh-13258
@@ -1090,7 +1090,7 @@ def test_iterable_items(self, dtype, rdtype):
             ('object', (int, long)),
             ('category', (int, long))])
     @pytest.mark.parametrize('typ', [Series, Index])
-    @pytest.mark.filterwarnings("ignore::FutureWarning")
+    @pytest.mark.filterwarnings("ignore:\\n    Passing:FutureWarning")
     def test_iterable_map(self, typ, dtype, rdtype):
         # gh-13236
         # coerce iteration to underlying python / pandas types