Skip to content

Commit 31f6099

Browse files
committed
Applied changes according to reviews by @jreback
1 parent 79ee155 commit 31f6099

File tree

2 files changed

+21
-4
lines changed

2 files changed

+21
-4
lines changed

doc/source/whatsnew/v0.24.0.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -711,7 +711,7 @@ Reshaping
711711
- Bug in :func:`get_dummies` with Unicode attributes in Python 2 (:issue:`22084`)
712712
- Bug in :meth:`DataFrame.replace` raises ``RecursionError`` when replacing empty lists (:issue:`22083`)
713713
- Bug in :meth:`Series.replace` and meth:`DataFrame.replace` when dict is used as the `to_replace` value and one key in the dict is is another key's value, the results were inconsistent between using integer key and using string key (:issue:`20656`)
714-
- Bug in :meth:`DataFrame.drop_duplicates` for empty DataFrame throws error (:issue:`20516`)
714+
- Bug in :meth:`DataFrame.drop_duplicates` for empty ``DataFrame`` which incorrectly raises error (:issue:`20516`)
715715

716716
Build Changes
717717
^^^^^^^^^^^^^

pandas/tests/frame/test_duplicates.py

Lines changed: 20 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -265,9 +265,26 @@ def test_drop_duplicates_tuple():
265265

266266
def test_drop_duplicates_empty():
267267
# GH 20516
268-
df = DataFrame()
269-
result = df.drop_duplicates()
270-
tm.assert_frame_equal(result, df)
268+
expected = DataFrame()
269+
result = expected.drop_duplicates()
270+
tm.assert_frame_equal(result, expected)
271+
272+
expected = DataFrame(columns=[])
273+
result = expected.drop_duplicates()
274+
tm.assert_frame_equal(result, expected)
275+
276+
expected = DataFrame(columns=['A', 'B', 'C'])
277+
result = expected.drop_duplicates()
278+
tm.assert_frame_equal(result, expected)
279+
280+
expected = DataFrame(index=[])
281+
result = expected.drop_duplicates()
282+
tm.assert_frame_equal(result, expected)
283+
284+
expected = DataFrame(index=['A', 'B', 'C'])
285+
result = expected.drop_duplicates()
286+
tm.assert_frame_equal(result, expected)
287+
271288

272289

273290
def test_drop_duplicates_NA():

0 commit comments

Comments
 (0)