improving OutOfBoundsDatetime exception messages

Author: dannyi96

pandas/tests/arrays/categorical/test_take.py

@@ -29,7 +29,7 @@ def test_take_bounds(self, allow_fill):
         if allow_fill:
             msg = "indices are out-of-bounds"
         else:
-            msg = "index 4 is out of bounds for( axis 0 with)? size 3"
+            msg = "index 4 is  for( axis 0 with)? size 3"
         with pytest.raises(IndexError, match=msg):
             cat.take([4, 5], allow_fill=allow_fill)
 

pandas/tests/base/test_constructors.py

@@ -157,7 +157,8 @@ def test_constructor_datetime_outofbound(self, a, klass):
 
         # Explicit dtype specified
         # Forced conversion fails for all -> all cases raise error
-        msg = "Out of bounds"
+        msg = "Out of bounds|" \
+            f"Cannot convert \"{a[0]}\" at position 0 to datetime"
         with pytest.raises(pd.errors.OutOfBoundsDatetime, match=msg):
             klass(a, dtype="datetime64[ns]")
 

pandas/tests/indexes/datetimes/test_constructors.py

@@ -521,7 +521,7 @@ def test_construction_outofbounds(self):
         # coerces to object
         tm.assert_index_equal(Index(dates), exp)
 
-        msg = "Out of bounds nanosecond timestamp"
+        msg = f'Cannot convert "{dates[0]}" at position 0 to datetime'
         with pytest.raises(OutOfBoundsDatetime, match=msg):
             # can't create DatetimeIndex
             DatetimeIndex(dates)

pandas/tests/indexes/datetimes/test_scalar_compat.py

@@ -38,7 +38,7 @@ def test_dti_date(self):
     @pytest.mark.parametrize("data", [["1400-01-01"], [datetime(1400, 1, 1)]])
     def test_dti_date_out_of_range(self, data):
         # GH#1475
-        msg = "Out of bounds nanosecond timestamp: 1400-01-01 00:00:00"
+        msg = f'Cannot convert "{data[0]}" at position 0 to datetime'
         with pytest.raises(OutOfBoundsDatetime, match=msg):
             DatetimeIndex(data)
 

pandas/tests/tools/test_to_datetime.py

@@ -688,7 +688,7 @@ def test_to_datetime_dt64s(self, cache, dt):
         "dt", [np.datetime64("1000-01-01"), np.datetime64("5000-01-02")]
     )
     def test_to_datetime_dt64s_out_of_bounds(self, cache, dt):
-        msg = f"Cannot convert \"{dt}\" at position 0 to datetime"
+        msg = f'Cannot convert "{dt}" at position 0 to datetime'
         with pytest.raises(OutOfBoundsDatetime, match=msg):
             to_datetime(dt, errors="raise")
         msg = f"Out of bounds nanosecond timestamp: {dt}"
@@ -974,13 +974,16 @@ def test_datetime_outofbounds_scalar(self, value, format, infer):
         assert res is NaT
 
         if format is not None:
-            msg = f"is a bad directive in format|Cannot convert \"{value}\" at position 0 to datetime"
+            msg = (
+                "is a bad directive in format|"
+                f'Cannot convert "{value}" at position 0 to datetime'
+            )
             with pytest.raises(ValueError, match=msg):
                 to_datetime(
                     value, errors="raise", format=format, infer_datetime_format=infer
                 )
         else:
-            msg = f"Cannot convert \"{value}\" at position 0 to datetime"
+            msg = f'Cannot convert "{value}" at position 0 to datetime'
             with pytest.raises(OutOfBoundsDatetime, match=msg):
                 to_datetime(
                     value, errors="raise", format=format, infer_datetime_format=infer
@@ -1701,7 +1704,7 @@ def test_to_datetime_barely_out_of_bounds(self):
         # in an in-bounds datetime
         arr = np.array(["2262-04-11 23:47:16.854775808"], dtype=object)
 
-        msg = f"Cannot convert \"2262-04-11 23:47:16.854775808\" at position 0 to datetime"
+        msg = 'Cannot convert "2262-04-11 23:47:16.854775808" at position 0 to datetime'
         with pytest.raises(OutOfBoundsDatetime, match=msg):
             to_datetime(arr)
 
@@ -2594,7 +2597,7 @@ def test_invalid_origins_tzinfo(self):
     @pytest.mark.parametrize("format", [None, "%Y-%m-%d %H:%M:%S"])
     def test_to_datetime_out_of_bounds_with_format_arg(self, format):
         # see gh-23830
-        msg = f"Cannot convert \"2417-10-27 00:00:00\" at position 0 to datetime"
+        msg = 'Cannot convert "2417-10-27 00:00:00" at position 0 to datetime'
         with pytest.raises(OutOfBoundsDatetime, match=msg):
             to_datetime("2417-10-27 00:00:00", format=format)
 

pandas/tests/tslibs/test_array_to_datetime.py

@@ -125,7 +125,7 @@ def test_coerce_outside_ns_bounds(invalid_date, errors):
     kwargs = {"values": arr, "errors": errors}
 
     if errors == "raise":
-        msg = "Out of bounds nanosecond timestamp"
+        msg = f'Cannot convert "{arr[0]}" at position 0 to datetime'
 
         with pytest.raises(ValueError, match=msg):
             tslib.array_to_datetime(**kwargs)
@@ -170,7 +170,7 @@ def test_to_datetime_barely_out_of_bounds():
     # Close enough to bounds that dropping nanos
     # would result in an in-bounds datetime.
     arr = np.array(["2262-04-11 23:47:16.854775808"], dtype=object)
-    msg = "Out of bounds nanosecond timestamp: 2262-04-11 23:47:16"
+    msg = f'Cannot convert "{arr[0]}" at position 0 to datetime'
 
     with pytest.raises(tslib.OutOfBoundsDatetime, match=msg):
         tslib.array_to_datetime(arr)