Skip to content

Commit 23ad133

Browse files
Daniel SaxtonDaniel Saxton
Daniel Saxton
authored and
Daniel Saxton
committed
Break into own test, parametrize
1 parent bac1eb5 commit 23ad133

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

pandas/tests/reductions/test_reductions.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -228,16 +228,17 @@ def test_minmax_timedelta64(self):
228228
assert idx.argmin() == 0
229229
assert idx.argmax() == 2
230230

231-
for op in ["min", "max"]:
232-
# Return NaT
233-
obj = TimedeltaIndex([])
234-
assert pd.isna(getattr(obj, op)())
231+
@pytest.mark.parametrize("op", ["min", "max"])
232+
def test_minmax_timedelta_empty_or_na(self, op):
233+
# Return NaT
234+
obj = TimedeltaIndex([])
235+
assert pd.isna(getattr(obj, op)())
235236

236-
obj = TimedeltaIndex([pd.NaT])
237-
assert pd.isna(getattr(obj, op)())
237+
obj = TimedeltaIndex([pd.NaT])
238+
assert pd.isna(getattr(obj, op)())
238239

239-
obj = TimedeltaIndex([pd.NaT, pd.NaT, pd.NaT])
240-
assert pd.isna(getattr(obj, op)())
240+
obj = TimedeltaIndex([pd.NaT, pd.NaT, pd.NaT])
241+
assert pd.isna(getattr(obj, op)())
241242

242243
def test_numpy_minmax_timedelta64(self):
243244
td = timedelta_range("16815 days", "16820 days", freq="D")

0 commit comments

Comments
 (0)