Skip to content

Commit 154252a

Browse files
committed
BUG: test case showing why assigning to dtype is unsafe
1 parent 2c81846 commit 154252a

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

pandas/tests/test_series.py

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1127,12 +1127,21 @@ def test_where(self):
11271127
self.assertRaises(ValueError, s.__setitem__, tuple([[[True, False]]]), [0,2,3])
11281128
self.assertRaises(ValueError, s.__setitem__, tuple([[[True, False]]]), [])
11291129

1130+
1131+
s = Series(np.arange(10), dtype=np.int32)
1132+
mask = s < 5
1133+
s[mask] = range(5)
1134+
expected = Series(np.arange(10), dtype=np.int32)
1135+
assert_series_equal(s, expected)
1136+
self.assertEquals(s.dtype, expected.dtype)
1137+
11301138
# GH3235
11311139
s = Series(np.arange(10))
11321140
mask = s < 5
11331141
s[mask] = range(5)
1134-
expected = Series(np.arange(10),dtype='float64')
1135-
assert_series_equal(s,expected)
1142+
expected = Series(np.arange(10))
1143+
assert_series_equal(s, expected)
1144+
self.assertEquals(s.dtype, expected.dtype)
11361145

11371146
s = Series(np.arange(10))
11381147
mask = s > 5

0 commit comments

Comments
 (0)