Skip to content

Commit 0d7c0cc

Browse files
committed
default to no sort on join
1 parent 73930c5 commit 0d7c0cc

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

pandas/core/indexes/period.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -911,14 +911,16 @@ def insert(self, loc, item):
911911
self[loc:].asi8))
912912
return self._shallow_copy(idx)
913913

914-
def join(self, other, how='left', level=None, return_indexers=False):
914+
def join(self, other, how='left', level=None, return_indexers=False,
915+
sort=False):
915916
"""
916917
See Index.join
917918
"""
918919
self._assert_can_do_setop(other)
919920

920921
result = Int64Index.join(self, other, how=how, level=level,
921-
return_indexers=return_indexers)
922+
return_indexers=return_indexers,
923+
sort=sort)
922924

923925
if return_indexers:
924926
result, lidx, ridx = result

pandas/tests/indexes/period/test_period.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -773,3 +773,9 @@ def test_map(self):
773773
result = index.map(lambda x: x.ordinal)
774774
exp = Index([x.ordinal for x in index])
775775
tm.assert_index_equal(result, exp)
776+
777+
@pytest.mark.parametrize('how', ['outer', 'inner', 'left', 'right'])
778+
def test_join_self(self, how):
779+
index = period_range('1/1/2000', periods=10)
780+
joined = index.join(index, how=how)
781+
assert index is joined

0 commit comments

Comments
 (0)