Skip to content

Commit 0864317

Browse files
committed
Hard code observed behavior to silence warning. See #35967
1 parent 6cca8c0 commit 0864317

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

pandas/core/generic.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -87,10 +87,15 @@
8787
from pandas.core.dtypes.missing import isna, notna
8888

8989
import pandas as pd
90-
from pandas.core import arraylike, indexing, missing, nanops
91-
import pandas.core.algorithms as algos
90+
from pandas.core import (
91+
algorithms as algos,
92+
arraylike,
93+
common as com,
94+
indexing,
95+
missing,
96+
nanops,
97+
)
9298
from pandas.core.base import PandasObject, SelectionMixin
93-
import pandas.core.common as com
9499
from pandas.core.construction import create_series_with_explicit_dtype
95100
from pandas.core.flags import Flags
96101
from pandas.core.indexes import base as ibase
@@ -6027,10 +6032,7 @@ def _convert(
60276032
validate_bool_kwarg(timedelta, "timedelta")
60286033
return self._constructor(
60296034
self._mgr.convert(
6030-
datetime=datetime,
6031-
numeric=numeric,
6032-
timedelta=timedelta,
6033-
copy=True,
6035+
datetime=datetime, numeric=numeric, timedelta=timedelta, copy=True,
60346036
)
60356037
).__finalize__(self)
60366038

@@ -6880,10 +6882,7 @@ def replace(
68806882
f"Expecting {len(to_replace)} got {len(value)} "
68816883
)
68826884
new_data = self._mgr.replace_list(
6883-
src_list=to_replace,
6884-
dest_list=value,
6885-
inplace=inplace,
6886-
regex=regex,
6885+
src_list=to_replace, dest_list=value, inplace=inplace, regex=regex,
68876886
)
68886887

68896888
elif to_replace is None:
@@ -10545,7 +10544,8 @@ def pct_change(
1054510544
def _agg_by_level(self, name, axis=0, level=0, skipna=True, **kwargs):
1054610545
if axis is None:
1054710546
raise ValueError("Must specify 'axis' when aggregating by level.")
10548-
grouped = self.groupby(level=level, axis=axis, sort=False)
10547+
# see pr-35967 for discussion about the observed keyword
10548+
grouped = self.groupby(level=level, axis=axis, sort=False, observed=False)
1054910549
if hasattr(grouped, name) and skipna:
1055010550
return getattr(grouped, name)(**kwargs)
1055110551
axis = self._get_axis_number(axis)

0 commit comments

Comments
 (0)