[fix] No overload variant of "isna" matches argument type "NAType" [call-overload] (#279)

* [fix] No overload variant of "isna" matches argument type "NAType" [call-overload]

Update `isna` & `notna` overloads inside pandas-stubs/core/dtypes/missing.pyi
Update `test_isna` function inside tests/test_pandas.py file

Refs #264

* [fix] No overload variant of "isna" matches argument type "NAType" [call-overload]

Update `isna` & `notna` overloads inside pandas-stubs/core/dtypes/missing.pyi
Update `test_isna` function inside tests/test_pandas.py file

Refs #264

* [fix] No overload variant of "isna" matches argument type "NAType" [call-overload]

Update `isna` & `notna` overloads inside pandas-stubs/core/dtypes/missing.pyi
Update `test_isna` function inside tests/test_pandas.py file

Refs #264

* [fix] No overload variant of "isna" matches argument type "NAType" [call-overload]

Update `isna` & `notna` overloads inside pandas-stubs/core/dtypes/missing.pyi
Update `test_isna` function inside tests/test_pandas.py file

Refs #264

* [fix] No overload variant of "isna" matches argument type "NAType" [call-overload]

Update `isna` & `notna` overloads inside pandas-stubs/core/dtypes/missing.pyi
Update `test_isna` function inside tests/test_pandas.py file

Refs #264

Author: LeMeteore

pandas-stubs/core/dtypes/missing.pyi

@@ -1,12 +1,18 @@
-from typing import overload
+from typing import (
+    Literal,
+    overload,
+)
 
 import numpy as np
+from numpy import typing as npt
 from pandas import (
     DataFrame,
     Index,
     Series,
 )
 
+from pandas._libs.missing import NAType
+from pandas._libs.tslibs import NaTType
 from pandas._typing import (
     ArrayLike,
     Scalar,
@@ -20,9 +26,11 @@ def isna(obj: DataFrame) -> DataFrame: ...
 @overload
 def isna(obj: Series) -> Series[bool]: ...
 @overload
-def isna(obj: Index | list | ArrayLike) -> np.ndarray: ...
+def isna(obj: Index | list | ArrayLike) -> npt.NDArray[np.bool_]: ...
 @overload
 def isna(obj: Scalar) -> bool: ...
+@overload
+def isna(obj: NaTType | NAType) -> Literal[True]: ...
 
 isnull = isna
 
@@ -31,8 +39,10 @@ def notna(obj: DataFrame) -> DataFrame: ...
 @overload
 def notna(obj: Series) -> Series[bool]: ...
 @overload
-def notna(obj: Index | list | ArrayLike) -> np.ndarray: ...
+def notna(obj: Index | list | ArrayLike) -> npt.NDArray[np.bool_]: ...
 @overload
 def notna(obj: Scalar) -> bool: ...
+@overload
+def notna(obj: NaTType | NAType) -> Literal[False]: ...
 
 notnull = notna

tests/test_pandas.py

@@ -3,10 +3,12 @@
 from typing import (
     TYPE_CHECKING,
     Any,
+    Literal,
     Union,
 )
 
 import numpy as np
+from numpy import typing as npt
 import pandas as pd
 from pandas.api.extensions import ExtensionArray
 from typing_extensions import assert_type
@@ -112,13 +114,30 @@ def test_types_json_normalize() -> None:
 
 
 def test_isna() -> None:
-    s = pd.Series([1, np.nan, 3.2])
-    check(assert_type(pd.isna(s), "pd.Series[bool]"), pd.Series, bool)
-    b: bool = pd.isna(np.nan)
-    ar: np.ndarray = pd.isna(s.to_list())
-    check(assert_type(pd.notna(s), "pd.Series[bool]"), pd.Series, bool)
-    b2: bool = pd.notna(np.nan)
-    ar2: np.ndarray = pd.notna(s.to_list())
+    # https://github.com/pandas-dev/pandas-stubs/issues/264
+    s1 = pd.Series([1, np.nan, 3.2])
+    check(assert_type(pd.isna(s1), "pd.Series[bool]"), pd.Series, bool)
+
+    s2 = pd.Series([1, 3.2])
+    check(assert_type(pd.notna(s2), "pd.Series[bool]"), pd.Series, bool)
+
+    df1 = pd.DataFrame({"a": [1, 2, 1, 2], "b": [1, 1, 2, np.nan]})
+    check(assert_type(pd.isna(df1), "pd.DataFrame"), pd.DataFrame)
+
+    idx1 = pd.Index([1, 2, np.nan])
+    check(assert_type(pd.isna(idx1), npt.NDArray[np.bool_]), np.ndarray, np.bool_)
+
+    idx2 = pd.Index([1, 2])
+    check(assert_type(pd.notna(idx2), npt.NDArray[np.bool_]), np.ndarray, np.bool_)
+
+    assert check(assert_type(pd.isna(pd.NA), Literal[True]), bool)
+    assert not check(assert_type(pd.notna(pd.NA), Literal[False]), bool)
+
+    assert check(assert_type(pd.isna(pd.NaT), Literal[True]), bool)
+    assert not check(assert_type(pd.notna(pd.NaT), Literal[False]), bool)
+
+    check(assert_type(pd.isna(2.5), bool), bool)
+    check(assert_type(pd.notna(2.5), bool), bool)
 
 
 # GH 55