Fix pd.read_excel (#33)

* Fix pd.read_excel

* add a test

* fix merge, cr feedback

* actually fix merge

Co-authored-by: hauntsaninja <>

Author: hauntsaninja

pandas-stubs/io/excel/__init__.pyi

@@ -0,0 +1,5 @@
+from pandas.io.excel._base import (
+    ExcelFile as ExcelFile,
+    ExcelWriter as ExcelWriter,
+    read_excel as read_excel,
+)

tests/test_frame.py

@@ -1,13 +1,11 @@
 # flake8: noqa: F841
-from datetime import (
-    date,
-    datetime,
-)
+from datetime import date
 import io
 from pathlib import Path
 import tempfile
 from typing import (
     Any,
+    Dict,
     Iterable,
     List,
     Tuple,
@@ -1012,6 +1010,15 @@ def test_frame_getitem_isin() -> None:
     assert_type(df[df.index.isin([1, 3, 5])], "pd.DataFrame")
 
 
+def test_read_excel() -> None:
+    pytest.skip()
+
+    # https://github.com/pandas-dev/pandas-stubs/pull/33
+    df11: pd.DataFrame = pd.read_excel("foo")
+    df12: pd.DataFrame = pd.read_excel("foo", sheet_name="sheet")
+    df13: Dict[Union[int, str], pd.DataFrame] = pd.read_excel("foo", sheet_name=["sheet"])
+
+
 def test_join() -> None:
     float_frame = pd.DataFrame(getSeriesData())
     # GH 29