let it fail

Author: twoertwein

.github/workflows/test.yml

@@ -58,6 +58,7 @@ jobs:
     - name: Install pandas-stubs and run tests on the installed stubs
       run: poetry run poe test_dist
 
+    # pandas nightly might have deprecated older python versions
     - if: matrix.python-version == '3.10' && matrix.os == 'ubuntu-latest'
       name: Run pytest (against pandas nightly)
       run: poetry run poe pytest --nightly

scripts/_job.py

@@ -35,7 +35,7 @@ def __rollback_job(steps: Deque[Step]):
                 )
 
 
-def run_job(steps: List[Step], exit_on_failure: bool = True) -> None:
+def run_job(steps: List[Step]) -> None:
     """
     Responsible to run steps with logs.
     """
@@ -66,5 +66,5 @@ def run_job(steps: List[Step], exit_on_failure: bool = True) -> None:
     if not failed:
         __rollback_job(rollback_steps)
 
-    if exit_on_failure and failed:
+    if failed:
         sys.exit(1)

scripts/test/__init__.py

@@ -50,4 +50,4 @@ def stubtest(allowlist: str, check_missing: bool, nightly: bool) -> None:
 
 def pytest(nightly: bool) -> None:
     steps = [_step.nightly] if nightly else []
-    run_job(steps + [_step.pytest], exit_on_failure=not nightly)
+    run_job(steps + [_step.pytest])

scripts/test/run.py

@@ -14,7 +14,7 @@ def pyright_src():
 
 
 def pytest():
-    cmd = ["pytest", "--cache-clear"]
+    cmd = ["pytest", "--cache-clear", "-Werror"]
     subprocess.run(cmd, check=True)
 
 

tests/test_io.py

@@ -163,43 +163,51 @@ def test_clipboard_iterator():
 def test_sas_bdat() -> None:
     path = pathlib.Path(CWD, "data", "airline.sas7bdat")
     check(assert_type(read_sas(path), DataFrame), DataFrame)
-    check(
+    with check(
         assert_type(read_sas(path, iterator=True), Union[SAS7BDATReader, XportReader]),
         SAS7BDATReader,
-    )
-    check(
+    ):
+        pass
+    with check(
         assert_type(read_sas(path, iterator=True, format="sas7bdat"), SAS7BDATReader),
         SAS7BDATReader,
-    )
-    check(
+    ):
+        pass
+    with check(
         assert_type(read_sas(path, chunksize=1), Union[SAS7BDATReader, XportReader]),
         SAS7BDATReader,
-    )
-    check(
+    ):
+        pass
+    with check(
         assert_type(read_sas(path, chunksize=1, format="sas7bdat"), SAS7BDATReader),
         SAS7BDATReader,
-    )
+    ):
+        pass
 
 
 def test_sas_xport() -> None:
     path = pathlib.Path(CWD, "data", "SSHSV1_A.xpt")
     check(assert_type(read_sas(path), DataFrame), DataFrame)
-    check(
+    with check(
         assert_type(read_sas(path, iterator=True), Union[SAS7BDATReader, XportReader]),
         XportReader,
-    )
-    check(
+    ):
+        pass
+    with check(
         assert_type(read_sas(path, iterator=True, format="xport"), XportReader),
         XportReader,
-    )
-    check(
+    ):
+        pass
+    with check(
         assert_type(read_sas(path, chunksize=1), Union[SAS7BDATReader, XportReader]),
         XportReader,
-    )
-    check(
+    ):
+        pass
+    with check(
         assert_type(read_sas(path, chunksize=1, format="xport"), XportReader),
         XportReader,
-    )
+    ):
+        pass
 
 
 def test_hdf():