TYP: fix almost all keyword-only reported by stubtest (#474)

* TYP: fix almost all keyword-only reported by stubtest

* opened pandas PR to make NDFame.fillna keyword-only

* duplicate overloads to make mypy pass

* address comments

* remaining comments

Author: twoertwein

pandas-stubs/_libs/tslibs/timestamps.pyi

@@ -142,7 +142,6 @@ class Timestamp(datetime):
         second: int | None = ...,
         microsecond: int | None = ...,
         tzinfo: _tzinfo | None = ...,
-        *,
         fold: Literal[0, 1] | None = ...,
     ) -> Timestamp: ...
     def astimezone(self: _DatetimeT, tz: _tzinfo | None = ...) -> _DatetimeT: ...

pandas-stubs/core/algorithms.pyi

@@ -40,8 +40,6 @@ def unique(values: ExtensionArray) -> ExtensionArray: ...
 def factorize(
     values: Sequence,
     sort: bool = ...,
-    # Not actually positional-only, used to handle deprecations in 1.5.0
-    *,
     use_na_sentinel: bool = ...,
     size_hint: int | None = ...,
 ) -> tuple[np.ndarray, np.ndarray]: ...

pandas-stubs/core/arrays/base.pyi

@@ -42,11 +42,9 @@ class ExtensionArray:
     ) -> ABCExtensionArray: ...
     def unique(self): ...
     def searchsorted(self, value, side: str = ..., sorter=...): ...
+    # TODO: remove keyword-only when pandas removed na_sentinel
     def factorize(
-        self,
-        # Not actually positional-only, used to handle deprecations in 1.5.0
-        *,
-        use_na_sentinel: bool = ...,
+        self, *, use_na_sentinel: bool = ...
     ) -> tuple[np.ndarray, ABCExtensionArray]: ...
     def repeat(self, repeats, axis=...): ...
     def take(

pandas-stubs/core/arrays/boolean.pyi

@@ -25,5 +25,5 @@ class BooleanArray(BaseMaskedArray):
     def __array_ufunc__(self, ufunc, method, *inputs, **kwargs): ...
     def __setitem__(self, key, value) -> None: ...
     def astype(self, dtype, copy: bool = ...): ...
-    def any(self, skipna: bool = ..., **kwargs): ...
-    def all(self, skipna: bool = ..., **kwargs): ...
+    def any(self, *, skipna: bool = ..., **kwargs): ...
+    def all(self, *, skipna: bool = ..., **kwargs): ...

pandas-stubs/core/arrays/categorical.pyi

@@ -158,22 +158,22 @@ class Categorical(ExtensionArray, PandasObject):
     def dropna(self): ...
     def value_counts(self, dropna: bool = ...): ...
     def check_for_ordered(self, op) -> None: ...
-    def argsort(self, ascending: bool = ..., kind: str = ..., *args, **kwargs): ...
+    def argsort(self, *, ascending: bool = ..., kind: str = ..., **kwargs): ...
     def sort_values(
-        self, inplace: bool = ..., ascending: bool = ..., na_position: str = ...
+        self, *, inplace: bool = ..., ascending: bool = ..., na_position: str = ...
     ): ...
     def view(self, dtype=...): ...
     def to_dense(self): ...
     def fillna(self, value=..., method=..., limit=...): ...
-    def take(self, indexer, allow_fill: bool = ..., fill_value=...): ...
+    def take(self, indexer, *, allow_fill: bool = ..., fill_value=...): ...
     def take_nd(self, indexer, allow_fill: bool = ..., fill_value=...): ...
     def __len__(self) -> int: ...
     def __iter__(self): ...
     def __contains__(self, key) -> bool: ...
     def __getitem__(self, key): ...
     def __setitem__(self, key, value) -> None: ...
-    def min(self, skipna: bool = ...): ...
-    def max(self, skipna: bool = ...): ...
+    def min(self, *, skipna: bool = ...): ...
+    def max(self, *, skipna: bool = ...): ...
     def mode(self, dropna: bool = ...): ...
     def unique(self): ...
     def equals(self, other): ...

pandas-stubs/core/arrays/datetimelike.pyi

@@ -40,7 +40,7 @@ class DatetimeLikeArrayMixin(ExtensionOpsMixin, ExtensionArray):
     def astype(self, dtype, copy: bool = ...): ...
     def view(self, dtype=...): ...
     def unique(self): ...
-    def take(self, indices, allow_fill: bool = ..., fill_value=...): ...
+    def take(self, indices, *, allow_fill: bool = ..., fill_value=...): ...
     def copy(self): ...
     def shift(self, periods: int = ..., fill_value=..., axis: int = ...): ...
     def searchsorted(self, value, side: str = ..., sorter=...): ...
@@ -77,8 +77,8 @@ class DatetimeLikeArrayMixin(ExtensionOpsMixin, ExtensionArray):
     def __rsub__(self, other): ...
     def __iadd__(self, other): ...
     def __isub__(self, other): ...
-    def min(self, axis=..., skipna: bool = ..., *args, **kwargs): ...
-    def max(self, axis=..., skipna: bool = ..., *args, **kwargs): ...
-    def mean(self, skipna: bool = ...): ...
+    def min(self, *, axis=..., skipna: bool = ..., **kwargs): ...
+    def max(self, *, axis=..., skipna: bool = ..., **kwargs): ...
+    def mean(self, *, skipna: bool = ...): ...
 
 def maybe_infer_freq(freq): ...

pandas-stubs/core/arrays/masked.pyi

@@ -26,6 +26,6 @@ class BaseMaskedArray(ExtensionArray, ExtensionOpsMixin):
     def isna(self): ...
     @property
     def nbytes(self) -> int: ...
-    def take(self, indexer, allow_fill: bool = ..., fill_value=...): ...
+    def take(self, indexer, *, allow_fill: bool = ..., fill_value=...): ...
     def copy(self): ...
     def value_counts(self, dropna: bool = ...): ...

pandas-stubs/core/arrays/sparse/array.pyi

@@ -43,15 +43,11 @@ class SparseArray(PandasObject, ExtensionArray, ExtensionOpsMixin):
     def shift(self, periods: int = ..., fill_value=...): ...
     def unique(self): ...
     def factorize(  # type: ignore[override]
-        self,
-        na_sentinel: int = ...,
-        # Not actually positional-only, used to handle deprecations in 1.5.0
-        *,
-        use_na_sentinel: bool = ...,
+        self, na_sentinel: int = ..., use_na_sentinel: bool = ...
     ) -> tuple[np.ndarray, SparseArray]: ...
     def value_counts(self, dropna: bool = ...): ...
     def __getitem__(self, key): ...
-    def take(self, indices, allow_fill: bool = ..., fill_value=...): ...
+    def take(self, indices, *, allow_fill: bool = ..., fill_value=...): ...
     def searchsorted(self, v, side: str = ..., sorter=...): ...
     def copy(self): ...
     def astype(self, dtype=..., copy: bool = ...): ...

pandas-stubs/core/base.pyi

@@ -87,5 +87,5 @@ class IndexOpsMixin:
         self, value, side: Literal["left", "right"] = ..., sorter=...
     ) -> int | list[int]: ...
     def drop_duplicates(
-        self, keep: NaPosition | Literal[False] = ...
+        self, *, keep: NaPosition | Literal[False] = ...
     ) -> IndexOpsMixin: ...

pandas-stubs/core/computation/eval.pyi

@@ -19,8 +19,6 @@ def eval(
     expr: str | BinOp,
     parser: Literal["pandas", "python"] = ...,
     engine: Literal["python", "numexpr"] | None = ...,
-    # Keyword only due to omitted deprecated argument
-    *,
     local_dict: dict[str, Any] | None = ...,
     global_dict: dict[str, Any] | None = ...,
     resolvers: list[Mapping] | None = ...,