Fix SecRemoteRules regression test not to depend on a specific error message #3211
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- After the GitHub macOS runner images were upgraded to macOS 14.6 (Sonoma), the test 'Include remote rules - failed download (Abort)' started failing because the error message reported by curl/OS is no longer 'HTTP response code said error'.
|
|
airween@, notice that the macOS builds triggered by the creation of the PR were assigned a macOS 14.5 runner, so them passing do not prove that the change fixes the issue. You should retrigger them until you see that they're run on a macOS 14.6 runner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Simplify the
Include remote rules - failed download (Abort)test expected parser error because it's not always the same in different curl/OS versions.why
This was detected after an update of the GitHub runner images to macOS 14.6 released yesterday:
Builds that were assigned a macOS runner image with this version would fail when running the
test/test-cases/regression/config-secremoterules.jsonregression tests.The test configuration depends on a specific error message from curl/OS (HTTP response code said error), which seems to have changed (Failure when receiving data from the peer).
This PR simplifies the test configuration and look just for
Failed to download, which is the prefix added by the libModSecurity parser when logging the parser error.