toupper/tolower is already receiving a copy, so it doesn't need to create a new one to transform it

Author: eduar-hte

src/utils/string.cc

@@ -154,28 +154,22 @@ std::string toHexIfNeeded(const std::string &str, bool escape_spec) {
 
 
 std::string tolower(std::string str) {
-    std::string value;
-    value.resize(str.length());
-
     std::transform(str.begin(),
             str.end(),
-            value.begin(),
+            str.begin(),
             ::tolower);
 
-    return value;
+    return str;
 }
 
 
 std::string toupper(std::string str) {
-    std::string value;
-    value.resize(str.length());
-
     std::transform(str.begin(),
             str.end(),
-            value.begin(),
+            str.begin(),
             ::toupper);
 
-    return value;
+    return str;
 }