Add schema name as Executor argument & fix default schema #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Vincz
commented
Jul 12, 2020
Vincz
commented
- Add schemaName in the ExecutorArgumentsEvent
- Make the GraphQL collector retrieve schema from ExecutorArgument instead of routing
- Consider default schema as the one with name 'default' or the first one defined
- Apply same logic to Annotation Parser
- Update doc
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Documented? | yes |
| Fixed tickets | #608, #712 |
| License | MIT |
- Add schemaName in the ExecutorArgumentsEvent - Make the GraphQL collector retrieve schema from ExecutorArgument instead of routing - Consider default schema as the one with name 'default' or the first one defined - Apply same logic to Annotation Parser - Update doc
Not sure why /** @var ExtensibleSchema $schema */ ExecutorArgumentsEvent::create($schemaName, $schema, $requestString, $contextValue, $rootValue, $variableValue, $operationName), was not accepted anymore to type hint $schema
mcg-web
reviewed
Jul 13, 2020
| foreach ($configs['definitions']['schema'] as $schemaName => $schema) { | ||
| $schemaQuery = $schema['query'] ?? null; | ||
| $schemaMutation = $schema['mutation'] ?? null; | ||
|
|
||
| if ($schemaQuery && $gqlName === $schemaQuery) { | ||
| $isRoot = true; | ||
| if ('default' == $schemaName) { | ||
| if ($defaultSchemaName == $schemaName) { |
There was a problem hiding this comment.
And a think the "if" conditions could also be simplified with $schemaQuery === $gqlName and $schemaMutation === $gqlName
| $isDefault = true; | ||
| } | ||
| } elseif ($schemaMutation && $gqlName === $schemaMutation) { | ||
| $isMutation = true; | ||
| $isRoot = true; | ||
| if ('default' == $schemaName) { | ||
| if ($defaultSchemaName == $schemaName) { |
mcg-web
approved these changes
Jul 13, 2020
| @@ -28,15 +28,19 @@ public function collect(Request $request, Response $response, Throwable $excepti | |||
| { | |||
| $error = false; | |||
| $count = 0; | |||
| $schema = false; | |||
| */ | ||
| public function getSchema(): string | ||
| public function getSchema() |
mcg-web
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.